From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: [PATCH net-next] net: phy: print error message in phy_error Date: Sun, 16 Dec 2018 16:52:21 +0100 Message-ID: <5b0ec181-0b51-6e4a-ca1a-097d44c2b7e9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Andrew Lunn , Florian Fainelli , David Miller Return-path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:38837 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729822AbeLPPw1 (ORCPT ); Sun, 16 Dec 2018 10:52:27 -0500 Received: by mail-wm1-f68.google.com with SMTP id m22so10213071wml.3 for ; Sun, 16 Dec 2018 07:52:26 -0800 (PST) Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: So far phy_error() silently stops the PHY state machine. If the network driver doesn't inform about a MDIO error then the user may wonder why his network is down. So let's inform the user. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 890ae1d73..a898fa411 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -739,6 +739,8 @@ static void phy_error(struct phy_device *phydev) phydev->state = PHY_HALTED; mutex_unlock(&phydev->lock); + phydev_err(phydev, "stopping PHY state machine due to error\n"); + phy_trigger_machine(phydev); } -- 2.20.0