Re: [PATCH net-next 0/2] net: macb: add some missing caps

[Nicolai Buchwitz <nb@tipi-net.de>]

On 13.11.2026 16:59, Théo Lebrun wrote:
> Out of all the compatibles modified, I only could test on Mobileye
> EyeQ5. The rest is information pulled from public datasheets.
> 
>  - QUEUE_DISABLE is important for suspend WoL (avoiding tieoff
>    descriptors) and will allow ethtool -L support for those platforms.
> 
>    The QUEUE_DISABLE patch was sent once as part of the set_channels
>    series [0]. Comments from Nicolai were addressed. Split to keep the
>    series small.
> 
>  - QBV is important, well, if you need QBV features.
> 
> Thanks,
> Have a nice day,
> Théo
> 
> [0]: 
> https://lore.kernel.org/netdev/20261016-macb-set-channels-v5-1-90ce0c0b8e75@bootlin.com/
> 
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> Théo Lebrun (2):
>       net: macb: add QUEUE_DISABLE capability to 3 compatibles
>       net: macb: add QBV capability to 4 compatibles
> 
>  drivers/net/ethernet/cadence/macb_main.c | 34 
> ++++++++++++++++++++++++--------
>  1 file changed, 26 insertions(+), 8 deletions(-)
> ---
> base-commit: 573af801552999954caa8347e4490b04cf4763f0
> change-id: 20261113-macb-caps-be72fa7ce119
> 
> Best regards,
> --
> Théo Lebrun <theo.lebrun@bootlin.com>

For the series:

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks,
Nicolai