From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: Richard Cochran <richardcochran@gmail.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Vadim Fedorenko <vadfed@fb.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: ocp: Fix error handling in ptp_ocp_device_init
Date: Fri, 22 Sep 2023 12:28:47 +0100 [thread overview]
Message-ID: <5b5704d6-3eca-70a8-4dc4-3a37653e3956@linux.dev> (raw)
In-Reply-To: <20230922094044.28820-1-dinghao.liu@zju.edu.cn>
On 22/09/2023 10:40, Dinghao Liu wrote:
> When device_add() fails, ptp_ocp_dev_release() will be called
> after put_device(). Therefore, it seems that the
> ptp_ocp_dev_release() before put_device() is redundant.
>
> Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Thanks!
Reviewed-by: Vadim Feodrenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2023-09-22 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:40 [PATCH] ptp: ocp: Fix error handling in ptp_ocp_device_init Dinghao Liu
2023-09-22 11:28 ` Vadim Fedorenko [this message]
2023-10-02 6:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b5704d6-3eca-70a8-4dc4-3a37653e3956@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=davem@davemloft.net \
--cc=dinghao.liu@zju.edu.cn \
--cc=jonathan.lemon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadfed@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).