From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"bjorn@kernel.org" <bjorn@kernel.org>,
"Janjua, Weqaar A" <weqaar.a.janjua@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Subject: RE: [PATCH bpf-next v2 0/6] AF_XDP Packet Drop Tracing
Date: Wed, 27 Jan 2021 10:17:51 +0000 [thread overview]
Message-ID: <5b5f55cb00f045a2a343625563e86293@intel.com> (raw)
In-Reply-To: <87bldccciw.fsf@toke.dk>
>
> Ciara Loftus <ciara.loftus@intel.com> writes:
>
> > This series introduces tracing infrastructure for AF_XDP sockets (xsks).
> > A trace event 'xsk_packet_drop' is created which can be enabled by
> toggling
> >
> > /sys/kernel/debug/tracing/events/xsk/xsk_packet_drop/enable
> >
> > When enabled and packets are dropped in the kernel, traces are generated
> > which describe the reason for the packet drop as well as the netdev and
> > qid information of the xsk which encountered the drop.
> >
> > Example traces:
> >
> > 507.588563: xsk_packet_drop: netdev: eth0 qid 0 reason: rxq full
> > 507.588567: xsk_packet_drop: netdev: eth0 qid 0 reason: packet too big
> > 507.588568: xsk_packet_drop: netdev: eth0 qid 0 reason: fq empty
> >
> > The event can also be monitored using perf:
> >
> > perf stat -a -e xsk:xsk_packet_drop
>
> Would it make sense to also hook this up to drop_monitor?
>
> -Toke
Thanks for bring that to my attention Toke. I think it makes sense.
I put together a quick prototype and it looks like a good fit.
Neil what do you think?
Perhaps as a follow up patch to the series in question however?
Ciara
prev parent reply other threads:[~2021-01-27 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 7:52 [PATCH bpf-next v2 0/6] AF_XDP Packet Drop Tracing Ciara Loftus
2021-01-26 7:52 ` [PATCH bpf-next v2 1/6] xsk: add tracepoints for packet drops Ciara Loftus
2021-01-26 22:51 ` Daniel Borkmann
2021-01-27 14:10 ` Loftus, Ciara
2021-01-27 23:15 ` Daniel Borkmann
2021-01-26 7:52 ` [PATCH bpf-next v2 2/6] selftests/bpf: restructure setting the packet count Ciara Loftus
2021-01-26 7:52 ` [PATCH bpf-next v2 3/6] selftests/bpf: add framework for xsk selftests Ciara Loftus
2021-01-26 7:52 ` [PATCH bpf-next v2 4/6] selftests/bpf: XSK_TRACE_DROP_RXQ_FULL test Ciara Loftus
2021-01-26 7:52 ` [PATCH bpf-next v2 5/6] selftests/bpf: XSK_TRACE_DROP_PKT_TOO_BIG test Ciara Loftus
2021-01-26 7:52 ` [PATCH bpf-next v2 6/6] selftests/bpf: XSK_TRACE_DROP_FQ_EMPTY test Ciara Loftus
2021-01-26 8:45 ` [PATCH bpf-next v2 0/6] AF_XDP Packet Drop Tracing Toke Høiland-Jørgensen
2021-01-27 10:17 ` Loftus, Ciara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b5f55cb00f045a2a343625563e86293@intel.com \
--to=ciara.loftus@intel.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=toke@redhat.com \
--cc=weqaar.a.janjua@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).