netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mohsin Bashir <mohsin.bashr@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, kuba@kernel.org,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, kernel-team@meta.com, sanmanpradhan@meta.com,
	sdf@fomichev.me, vadim.fedorenko@linux.dev, hmohsin@meta.com
Subject: Re: [PATCH net-next v2] eth: fbnic: Add support to write TCE TCAM entries
Date: Wed, 30 Oct 2024 18:19:45 -0700	[thread overview]
Message-ID: <5b6032d7-58f6-4e2d-98ec-68f7f55ae2c1@gmail.com> (raw)
In-Reply-To: <757b4a24-f849-4dae-9615-27c86f094a2e@lunn.ch>

Hi Andrew,

Basically, in addition to the RX TCAM (RPC) that you mentioned, we also 
have a TCAM on the TX path that enables traffic redirection for BMC. 
Unlike other NICs where BMC diversion is typically handled by firmware, 
FBNIC firmware does not touch anything host-related. In this patch, we 
are writing MACDA entries from the RPC (Rx Parser and Classifier) to the 
TX TCAM, allowing us to reroute any host traffic destined for BMC.

I will ensure that the commit message for the revised version clearly 
explains this.

On 10/30/24 11:34 AM, Andrew Lunn wrote:
> On Thu, Oct 24, 2024 at 03:31:35PM -0700, Mohsin Bashir wrote:
>> Add support for writing to the tce tcam to enable host to bmc traffic.
> 
> The commit message is not really helping me understand what is going
> on here. What entries are you adding to the TCAM? Normally a TCAM is
> used on ingress, but you are talking about host to BMC, which is
> egress?
> 
> 	Andrew


  reply	other threads:[~2024-10-31  1:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 22:31 [PATCH net-next v2] eth: fbnic: Add support to write TCE TCAM entries Mohsin Bashir
2024-10-25 12:52 ` Simon Horman
2024-10-25 15:19 ` Alexander Lobakin
2024-10-28 23:35   ` Jakub Kicinski
2024-10-29 15:30     ` Alexander Lobakin
2024-10-30  0:26       ` Jakub Kicinski
2024-10-30 18:34 ` Andrew Lunn
2024-10-31  1:19   ` Mohsin Bashir [this message]
     [not found]   ` <97383310-c846-493a-a023-4d8033c5680b@gmail.com>
2024-10-31 12:43     ` Andrew Lunn
2024-10-31 22:13       ` Mohsin Bashir
2024-11-01 12:33         ` Andrew Lunn
2024-11-01 23:04           ` Alexander H Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b6032d7-58f6-4e2d-98ec-68f7f55ae2c1@gmail.com \
    --to=mohsin.bashr@gmail.com \
    --cc=alexanderduyck@fb.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hmohsin@meta.com \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sanmanpradhan@meta.com \
    --cc=sdf@fomichev.me \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).