From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C62FB37C11B for ; Wed, 27 May 2026 15:58:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779897524; cv=none; b=DpkaJwVZn83ma3bFLk6vhM0Bx+Utpjwlbmt1e11yS33aWbNYNN+IRjNKUIWxfw5WQKs94FxJfDD/9SYqLU25PEBanpcLAToCIA+BE4VtqLfVmRwGmOrPxC1lYXM4PcUOLSNUuZiO90YV2Xku/5xMJS6FmfKkEQ5rf9uxL8rf9LI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779897524; c=relaxed/simple; bh=ZGaVfRe4pwKSIV3A0DKoI5aIPRxMnxWQp5Scj94gPUE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zu6PdeUIqB/5uSz+M5E3qxeo21ewinIvIhs3OsrOGisD368bUiVS92BmECtUtUf22GpsjSnMapLqGdpYo/mJgaSkc7M/Hhg41Tn+3816MTtKsv/9XGU1HcuWDSJxwvNkFxqRzwS0jOrWdaS4HEVZJ+HhD0budJu87XCIxrnhV8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WFmtSNxR; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WFmtSNxR" Message-ID: <5b617773-92c4-4d8d-831e-a74ef0c76b33@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779897520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oxn2nvn0dCOHkFr6MxG50HZrEMR0vc9BDbUv8aE3L28=; b=WFmtSNxRJPQ2G05aFbgAd5amJDy+kTP2H5QF97iE97dUoMfX5TxBFLHB6KaiZPH7KGknzr yWc3404aejcrxF6ngr5r83bkdInXeTfqfzLWcsUL2SZSzZkUm4ExRGUCzpTzev3m6fm1XV UbSjAvSxbT7lbMC2/Mo7J2/7qOHKGzg= Date: Wed, 27 May 2026 16:58:10 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net] net: remove SIOCSHWTSTAMP and SIOCGHWTSTAMP from ndo_eth_ioctl comment To: Xuan Zhuo , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , Vladimir Oltean , Florian Fainelli References: <20260527120936.24169-1-xuanzhuo@linux.alibaba.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20260527120936.24169-1-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 27/05/2026 13:09, Xuan Zhuo wrote: > Since commit 4ee58e1e5680 ("net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP > ioctls to dedicated handlers"), SIOCSHWTSTAMP and SIOCGHWTSTAMP are no > longer dispatched through dev_eth_ioctl() / ndo_eth_ioctl(). They are > now handled by their own dedicated functions dev_set_hwtstamp() and > dev_get_hwtstamp() in the ioctl path. > > However, the comment describing ndo_eth_ioctl in netdevice.h still > lists these two ioctls, which is misleading for driver developers who > may incorrectly assume they need to handle hardware timestamping > commands in their ndo_eth_ioctl implementation. > > Remove the stale references from the comment to accurately reflect that > ndo_eth_ioctl only handles SIOCGMIIPHY, SIOCGMIIREG and SIOCSMIIREG. > > Fixes: 4ee58e1e5680 ("net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP ioctls to dedicated handlers") > Signed-off-by: Xuan Zhuo > --- > include/linux/netdevice.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index bf3dd9b2c1a7..7309467d7873 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1149,8 +1149,8 @@ struct netdev_net_notifier { > * SIOCBONDSLAVEINFOQUERY, and SIOCBONDINFOQUERY > * > * * int (*ndo_eth_ioctl)(struct net_device *dev, struct ifreq *ifr, int cmd); > - * Called for ethernet specific ioctls: SIOCGMIIPHY, SIOCGMIIREG, > - * SIOCSMIIREG, SIOCSHWTSTAMP and SIOCGHWTSTAMP. > + * Called for ethernet specific ioctls: SIOCGMIIPHY, SIOCGMIIREG and > + * SIOCSMIIREG. > * > * int (*ndo_set_config)(struct net_device *dev, struct ifmap *map); > * Used to set network devices bus interface parameters. This interface Reviewed-by: Vadim Fedorenko