From: Florian Fainelli <f.fainelli@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Clément Léger" <clement.leger@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH net-next 8/9] net: dsa: rzn1_a5psw: Convert to platform remove callback returning void
Date: Mon, 18 Sep 2023 13:53:43 -0700 [thread overview]
Message-ID: <5b8a126e-2eb3-a0cf-9b68-e9b7b9481cec@gmail.com> (raw)
In-Reply-To: <20230918191916.1299418-9-u.kleine-koenig@pengutronix.de>
On 9/18/23 12:19, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2023-09-18 20:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 19:19 [PATCH net-next 0/9] net: dsa: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-18 19:19 ` [PATCH net-next 1/9] net: dsa: b53: " Uwe Kleine-König
2023-09-18 19:26 ` Florian Fainelli
2023-09-18 19:19 ` [PATCH net-next 2/9] net: dsa: bcm_sf2: " Uwe Kleine-König
2023-09-18 19:26 ` Florian Fainelli
2023-09-18 19:19 ` [PATCH net-next 3/9] net: dsa: hirschmann: " Uwe Kleine-König
2023-09-18 20:26 ` Andrew Lunn
2023-09-18 20:51 ` Florian Fainelli
2023-09-19 15:27 ` Kurt Kanzenbach
2023-09-18 19:19 ` [PATCH net-next 4/9] net: dsa: lantiq_gswip: " Uwe Kleine-König
2023-09-18 20:26 ` Andrew Lunn
2023-09-18 20:51 ` Florian Fainelli
2023-09-18 19:19 ` [PATCH net-next 5/9] net: dsa: mt7530: " Uwe Kleine-König
2023-09-18 20:27 ` Andrew Lunn
2023-09-18 20:52 ` Florian Fainelli
2023-09-19 8:14 ` Daniel Golle
2023-09-18 19:19 ` [PATCH net-next 6/9] net: dsa: ocelot: " Uwe Kleine-König
2023-09-18 20:27 ` Andrew Lunn
2023-09-18 20:53 ` Florian Fainelli
2023-09-18 19:19 ` [PATCH net-next 7/9] net: dsa: realtek: " Uwe Kleine-König
2023-09-18 20:28 ` Andrew Lunn
2023-09-18 20:53 ` Florian Fainelli
2023-09-19 8:04 ` Alvin Šipraga
2023-09-18 19:19 ` [PATCH net-next 8/9] net: dsa: rzn1_a5psw: " Uwe Kleine-König
2023-09-18 20:28 ` Andrew Lunn
2023-09-18 20:53 ` Florian Fainelli [this message]
2023-09-19 7:05 ` Geert Uytterhoeven
2023-09-18 19:19 ` [PATCH net-next 9/9] net: dsa: vitesse-vsc73xx: " Uwe Kleine-König
2023-09-18 20:28 ` Andrew Lunn
2023-09-18 20:53 ` Florian Fainelli
2023-09-20 9:30 ` [PATCH net-next 0/9] net: dsa: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8a126e-2eb3-a0cf-9b68-e9b7b9481cec@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).