From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D92711CB0 for ; Sat, 23 Dec 2023 19:09:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MV76qlEQ" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a26db4e9676so49774666b.3 for ; Sat, 23 Dec 2023 11:09:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703358576; x=1703963376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=fG4oNinYk8QMmXNSPRxehfWZhCjQ3wv6ciRyA2tb0kk=; b=MV76qlEQevpUTtB9b6ZQzxwqOJBcFmHKRJlUiId2NHBngEN9/137DlUqL1Teh69sXD IgY86cX0UEmPsQojarxQhEJ/uFVReMDpfBc2BOTbuc4GSYshHGLRwTSezq6vZvCU0lTh 7M7M1yFvpnygId1kfrk4AXHc+REdnpHUCq/UxmTtOFat9jMk4688P0+/0/y1I3QRPzdz LPOdwn8oVkS9YIrl272E+ioCMf2n+2M4oSLEYgypiE0M4X5+TmyQfgSDCp6fEnOZ48hS 304poMfZvQtDf+bvQSLQtIOiqF8wnlmNgfEaJcIUh5XincZBqlYUKEttqFibTduJb0An FcRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703358576; x=1703963376; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fG4oNinYk8QMmXNSPRxehfWZhCjQ3wv6ciRyA2tb0kk=; b=H9qQP47/dV5ExdhqQHoxkonRqI1H4UH2ROMl4xrvvHygMVnRSRThvQ2qnzTdQSGCU5 KZWNhwMnDXfpSUXWWHxSgFiLeLrLbR9F8EQlqjeK8cLjHfCLPsX5eoYay/2PtgdtRLL2 ADDYFKrpD3clcrSIo15W+pN+SnqKpXcyD0GUyeINvjBthzb0R1Z8V1jBZ1Fw7EeQn6fR lFAqFMqOPQuNSW5tMqYaeYmJGWYoSpsl1tK+9/uutUrvTmYTB8F7THrQzzIgOtC3Am7h ISILNH64mkEHXS4pcZdz9Q9dsykW19hXIcBAePudmvpFxz+GKW67Um4k8saVvei2i5EO AM1g== X-Gm-Message-State: AOJu0Yy4RvbRAL4CYSc8xhZlQRKeo3P0djXLdgzJfH2d8jCZgRDCG7b6 m58cCTQoypywzbMac73IPwY= X-Google-Smtp-Source: AGHT+IGHdvJms3z/vEojgr56cqknJRWwhVgt7BfbKujrjIm4C71XkAFQAqMjG3TgiVt7dsP6HJVSLw== X-Received: by 2002:a17:906:3f46:b0:a23:6282:e42f with SMTP id f6-20020a1709063f4600b00a236282e42fmr784868ejj.270.1703358575343; Sat, 23 Dec 2023 11:09:35 -0800 (PST) Received: from ?IPV6:2a01:c23:bc40:a000:ac00:bade:9090:bec9? (dynamic-2a01-0c23-bc40-a000-ac00-bade-9090-bec9.c23.pool.telefonica.de. [2a01:c23:bc40:a000:ac00:bade:9090:bec9]) by smtp.googlemail.com with ESMTPSA id x22-20020a170906135600b00a235f3b8259sm3282642ejb.186.2023.12.23.11.09.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Dec 2023 11:09:34 -0800 (PST) Message-ID: <5b9ae8ea-5817-47b0-9d51-0b15098db5cf@gmail.com> Date: Sat, 23 Dec 2023 20:09:33 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 00/15] Realtek RTL822x PHY rework to c45 and SerDes interface switching To: =?UTF-8?Q?Marek_Beh=C3=BAn?= Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Russell King , Alexander Couzens , Daniel Golle , Willy Liu , Ioana Ciornei , =?UTF-8?Q?Marek_Moj=C3=ADk?= , =?UTF-8?Q?Maximili=C3=A1n_Maliar?= References: <20231220155518.15692-1-kabel@kernel.org> <20231220172518.50f56aaa@dellmb> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <20231220172518.50f56aaa@dellmb> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 20.12.2023 17:25, Marek Behún wrote: > On Wed, 20 Dec 2023 17:20:07 +0100 > Heiner Kallweit wrote: > >> On 20.12.2023 16:55, Marek Behún wrote: >>> Hi, >>> >>> this series reworks the realtek PHY driver's support for rtl822x >>> 2.5G transceivers: >>> >>> - First I change the driver so that the high level driver methods >>> only use clause 45 register accesses (the only clause 22 accesses >>> are left when accessing c45 registers indirectly, if the MDIO bus >>> does not support clause 45 accesses). >>> The driver starts using the genphy_c45_* methods. >>> >>> At this point the driver is ready to be used on a MDIO bus capable >>> of only clause 45 accesses, but will still work on clause 22 only >>> MDIO bus. >>> >>> - I then add support for SerDes mode switching between 2500base-x >>> and sgmii, based on autonegotiated copper speed. >>> >>> All this is done so that we can support another 2.5G copper SFP >>> module, which is enabled by the last patch. >>> >> >> Has been verified that the RTL8125-integrated PHY's still work >> properly with this patch set? >> > > Hi Heiner, > > no, I wanted to send you an email to test this. I do not have the > controllers with integrates PHYs. > > Can you test this? > > Also do you have a controller where the rtlgen driver is used but it > only supports 1gbps ? I.e. where the PHY ID is RTL_GENERIC_PHYID > (0x001cc800). > > I am asking because I am told that it also is clause 45, so the drivers > can potentially be merged completely (the rtl822x_ functions can be > merged with rtlgen_ functions and everything rewritten to clause 45, > and gentphy_c45_ functions can be used). > At least on RTL8168h indirect MMD reads return 0 always. IIRC this was the reason why the rtlgen functions use the vendor-specific registers. > Marek