From: Timur Tabi <timur@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Hemanth Puranik <hpuranik@codeaurora.org>
Subject: Re: [PATCH net] net: qcom/emac: Add missing of_node_put()
Date: Wed, 13 Jun 2018 15:45:02 -0500 [thread overview]
Message-ID: <5bae4b8f-6235-8c28-61f9-88d574084d6a@codeaurora.org> (raw)
In-Reply-To: <20180611130345.15172-1-yuehaibing@huawei.com>
On 06/11/2018 08:03 AM, YueHaibing wrote:
> Add missing of_node_put() call for device node returned by
> of_parse_phandle().
>
> Signed-off-by: YueHaibing<yuehaibing@huawei.com>
Acked-by: Timur Tabi <timur@codeaurora.org>
This seems legit. The comment for of_find_device_by_node() that says
the np needs to be released was added after the code was written, so
it's possible that I didn't know at the time that this was a requirement.
However, I no longer have the ability to test EMAC on device tree
platforms, so I can't verify this code.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-06-13 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 13:03 [PATCH net] net: qcom/emac: Add missing of_node_put() YueHaibing
2018-06-12 2:03 ` Timur Tabi
2018-06-13 20:45 ` Timur Tabi [this message]
2018-06-15 0:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bae4b8f-6235-8c28-61f9-88d574084d6a@codeaurora.org \
--to=timur@codeaurora.org \
--cc=davem@davemloft.net \
--cc=hpuranik@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).