From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH net] net: qcom/emac: Add missing of_node_put() Date: Wed, 13 Jun 2018 15:45:02 -0500 Message-ID: <5bae4b8f-6235-8c28-61f9-88d574084d6a@codeaurora.org> References: <20180611130345.15172-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Hemanth Puranik To: YueHaibing , davem@davemloft.net Return-path: In-Reply-To: <20180611130345.15172-1-yuehaibing@huawei.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 06/11/2018 08:03 AM, YueHaibing wrote: > Add missing of_node_put() call for device node returned by > of_parse_phandle(). > > Signed-off-by: YueHaibing Acked-by: Timur Tabi This seems legit. The comment for of_find_device_by_node() that says the np needs to be released was added after the code was written, so it's possible that I didn't know at the time that this was a requirement. However, I no longer have the ability to test EMAC on device tree platforms, so I can't verify this code. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.