public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Luke Howard <lukeh@padl.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	netdev@vger.kernel.org, Kieran Tyrrell <kieran@sienda.com>,
	Max Hunter <max@huntershome.org>
Subject: Re: net: dsa: mv88e6xxx architecture
Date: Sat, 21 Dec 2024 22:36:22 +0100	[thread overview]
Message-ID: <5bdb17e0-cd7a-44e3-bdd4-d0686ea61b14@lunn.ch> (raw)
In-Reply-To: <F8AE422A-2A10-4C39-A431-DA6E668797D3@padl.com>

On Sat, Dec 21, 2024 at 09:52:27AM +1100, Luke Howard wrote:
>     For a moment, forget about Marvell. Think about a purely software
>     solution, maybe using the Linux bridge, and a collection of e1000e
>     cards. Does the same problem exist? How would you solve it?
> 
> 
> One could:
> 
> * Add (e.g.) TCA_MQPRIO_TC_ENTRY_SRP to indicate the TC is associated with a
> SRP class
> * Add (e.g.) NTF_EXT_SRP_MANAGED to indicate the FDB/MDB entry was inserted by
> the SRP daemon

Doesn't FDB/MDB imply you have a bridge? What about an isolated port
which is not a member of a bridge, there is only local traffic?

> Packets with TCs marked TCA_MQPRIO_TC_ENTRY_SRP to DAs not marked
> NTF_EXT_SRP_MANAGED would be dropped (or deprioritised).
> 
> For mv88e6xxx, TCA_MQPRIO_TC_ENTRY_SRP would be supported for “AVB” traffic
> classes, and NTF_EXT_SRP_MANAGED would map to MV88E6XXX_G1_ATU_DATA_STATE_
> {UC,MC}_STATIC_AVB_NRL.
> 
> Or, we do nothing. As far as I can tell the biggest issue with not supporting
> this is whether the bridge would pass the Avnu test suite. That’s not so
> important to me, but it might be to some other users.

It is back to, we use the hardware to accelerate what Linux can
already do in software. If you only use the switch ports in isolated
mode, no bridge, you could probably get away with not supporting AVB
on the linux bridge. But if you need the software bridge to setup the
acceleration via a hardware bridge, you will need the software bridge
to work with AVB without acceleration.

	Andrew

  parent reply	other threads:[~2024-12-21 21:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 21:02 net: dsa: mv88e6xxx architecture Luke Howard
2024-12-20 12:10 ` Vladimir Oltean
2024-12-20 21:46   ` Luke Howard
     [not found]   ` <7E1DC313-33DE-4AA8-AD52-56316C07ABC4@padl.com>
2024-12-20 22:33     ` Andrew Lunn
2024-12-20 22:56       ` Luke Howard
     [not found]       ` <F8AE422A-2A10-4C39-A431-DA6E668797D3@padl.com>
2024-12-21 21:36         ` Andrew Lunn [this message]
2024-12-21 22:15           ` Luke Howard
2024-12-20 22:54     ` Vladimir Oltean
2024-12-20 22:59       ` Luke Howard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bdb17e0-cd7a-44e3-bdd4-d0686ea61b14@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=kieran@sienda.com \
    --cc=lukeh@padl.com \
    --cc=max@huntershome.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox