netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: firasuke@gmail.com
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup")
Date: Tue, 1 Jan 2019 15:38:44 +0100	[thread overview]
Message-ID: <5bf4cb4e-5e87-7892-bd84-0509ff435e03@gmail.com> (raw)
In-Reply-To: <20190101111334.3115-1-firasuke@gmail.com>

On 01.01.2019 12:13, firasuke@gmail.com wrote:
> From: Firas Khalil Khana <firasuke@gmail.com>
> 
> Fixes: 377a09902a57 ("configure: Minor code cleanup")
> 
I think the patch should be annotated iproute2 to make clear
it's not about the kernel. And it's missing a description
which issue was fixed.

> Signed-off-by: Firas Khalil Khana <firasuke@gmail.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index b85eb58b..45fcffb6 100755
> --- a/configure
> +++ b/configure
> @@ -115,7 +115,7 @@ EOF
>  check_xt_old_internal_h()
>  {
>      # bail if previous XT checks has already succeeded.
> -    grep -q if grep -q TC_CONFIG_XT $CONFIG && return
> +    grep -q TC_CONFIG_XT $CONFIG && return
>  
>      #check if we need our own internal.h
>      cat >$TMPDIR/ipttest.c <<EOF
> 

      reply	other threads:[~2019-01-01 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01 11:13 [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup") firasuke
2019-01-01 14:38 ` Heiner Kallweit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bf4cb4e-5e87-7892-bd84-0509ff435e03@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=firasuke@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).