* [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup")
@ 2019-01-01 11:13 firasuke
2019-01-01 14:38 ` Heiner Kallweit
0 siblings, 1 reply; 2+ messages in thread
From: firasuke @ 2019-01-01 11:13 UTC (permalink / raw)
To: netdev; +Cc: Firas Khalil Khana
From: Firas Khalil Khana <firasuke@gmail.com>
Fixes: 377a09902a57 ("configure: Minor code cleanup")
Signed-off-by: Firas Khalil Khana <firasuke@gmail.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b85eb58b..45fcffb6 100755
--- a/configure
+++ b/configure
@@ -115,7 +115,7 @@ EOF
check_xt_old_internal_h()
{
# bail if previous XT checks has already succeeded.
- grep -q if grep -q TC_CONFIG_XT $CONFIG && return
+ grep -q TC_CONFIG_XT $CONFIG && return
#check if we need our own internal.h
cat >$TMPDIR/ipttest.c <<EOF
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup")
2019-01-01 11:13 [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup") firasuke
@ 2019-01-01 14:38 ` Heiner Kallweit
0 siblings, 0 replies; 2+ messages in thread
From: Heiner Kallweit @ 2019-01-01 14:38 UTC (permalink / raw)
To: firasuke; +Cc: netdev, Stephen Hemminger
On 01.01.2019 12:13, firasuke@gmail.com wrote:
> From: Firas Khalil Khana <firasuke@gmail.com>
>
> Fixes: 377a09902a57 ("configure: Minor code cleanup")
>
I think the patch should be annotated iproute2 to make clear
it's not about the kernel. And it's missing a description
which issue was fixed.
> Signed-off-by: Firas Khalil Khana <firasuke@gmail.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index b85eb58b..45fcffb6 100755
> --- a/configure
> +++ b/configure
> @@ -115,7 +115,7 @@ EOF
> check_xt_old_internal_h()
> {
> # bail if previous XT checks has already succeeded.
> - grep -q if grep -q TC_CONFIG_XT $CONFIG && return
> + grep -q TC_CONFIG_XT $CONFIG && return
>
> #check if we need our own internal.h
> cat >$TMPDIR/ipttest.c <<EOF
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-01 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-01 11:13 [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup") firasuke
2019-01-01 14:38 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).