From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7CE7C43381 for ; Tue, 26 Mar 2019 20:04:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 914C02075C for ; Tue, 26 Mar 2019 20:04:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xv/lgj+F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732623AbfCZUES (ORCPT ); Tue, 26 Mar 2019 16:04:18 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:35824 "EHLO mail-wm1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732176AbfCZUES (ORCPT ); Tue, 26 Mar 2019 16:04:18 -0400 Received: by mail-wm1-f51.google.com with SMTP id y197so14350596wmd.0 for ; Tue, 26 Mar 2019 13:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=MnVnyAH/2P5MBIi4Ka9iTHgUHrR+UwnOc5DftH5KIEA=; b=Xv/lgj+FLkFc6JVIgidI134wYsiFL8E8MSmogrs3ux0N49yWBK9DWA9ImbvucmPFol OrHhWCwk1TRrBzZZf+gVHW8fORZ26aVyD+j2ObgadVov8y8LE+Q6TwwkverxafRB1TKi l0O1IwbPWUMp6vr1b5foK/gSNDrdfAnfQ2qws4C8QtbA/Pk+cVbGr+0zoKS1B3HeEd/F HBwj/5b72etToN9nmrRMKtCHZH0qzlrYdPbEv4xlorVIXmfh27hGxXbuHKye7DJLhomm O5Yxeluw0cdsj8Zvp0F7YMKOtCFqPio85p5qCVlyC23pAVhfrhLk3LvYQGMNJ0ntqpDB X4fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=MnVnyAH/2P5MBIi4Ka9iTHgUHrR+UwnOc5DftH5KIEA=; b=D1Th0CUjlqswn2L6ncfiGQCZm1Vc9ayosFx1HQZHOlHG2OFwdA8841ep/O2DpC+G13 wlsrjwv9uI9K39Iky0/N76VPsk0QoyTFGCH49eA4Oeo0QMEDPHhTYA2O2riebClRMCFp amXF7aDOYxndIn6fGg+O/nRXTs0oQLQWQn4mXDpWmIAm2XcpRTjiBKSe99W7mb9zXw8q aT+T7G4Ht9K/auQfSSfnXPFKJM23pKjMBTcxAeYBJEJPZMyFPWPYSlwg9bfsMGYfW0vS sKJSLnbAj/vmYNxsZEG+E+ixS0mf9qoY56+0FnZBpgUiW25cO4vO6F8LWYRQ0O2Y48BQ hNOw== X-Gm-Message-State: APjAAAW91/UO/QjlBiZ4zFTjeU87Zaf+WRrgspOzq1sd9e5AvD5b4Tva CKK5jX5W3MbXJOiGJZzTQqEiq7JS X-Google-Smtp-Source: APXvYqxB2mJNpH2mtO0SCihkFtNB0hrECvgEHSFZbEAdjXmMPMOqffOXdGZUii8MUyVC6vHCq0bXuQ== X-Received: by 2002:a1c:a993:: with SMTP id s141mr16145638wme.152.1553630655971; Tue, 26 Mar 2019 13:04:15 -0700 (PDT) Received: from ?IPv6:2003:ea:8bc4:dc00:8c1:5e0b:d735:c3dc? (p200300EA8BC4DC0008C15E0BD735C3DC.dip0.t-ipconnect.de. [2003:ea:8bc4:dc00:8c1:5e0b:d735:c3dc]) by smtp.googlemail.com with ESMTPSA id w21sm22084953wmc.4.2019.03.26.13.04.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 13:04:15 -0700 (PDT) To: Edward Cree , Jesper Dangaard Brouer From: Heiner Kallweit Subject: netif_receive_skb_list and interrupts enabled/disabled Cc: "netdev@vger.kernel.org" Message-ID: <5c170def-4c09-8da2-e0cd-6fc29881031f@gmail.com> Date: Tue, 26 Mar 2019 21:04:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A question inspired by 0a25d92c6f4f ("dpaa2-eth: use netif_receive_skb_list"): kerneldoc of netif_receive_skb_list states that interrupts should be enabled. When used from NAPI context irqs typically are disabled. And if the NAPI budget is fully consumed then interrupts don't get enabled in the same NAPI poll loop. How is this supposed to play together? Thanks, Heiner