From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
<netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
<linux-doc@vger.kernel.org>, <corbet@lwn.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 5/5] ice: refactor to use helpers
Date: Wed, 5 Jun 2024 06:01:03 +0200 [thread overview]
Message-ID: <5c19f080-8ad2-4e9a-b664-b5e3e45a852a@intel.com> (raw)
In-Reply-To: <20240604221327.299184-6-jesse.brandeburg@intel.com>
On 6/5/24 00:13, Jesse Brandeburg wrote:
> Use the ice_netdev_to_pf() helper in more places and remove a bunch of
> boilerplate code. Not every instance could be replaced due to use of the
> netdev_priv() output or the vsi variable within a bunch of functions.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 42 ++++++-------------
> .../net/ethernet/intel/ice/ice_flex_pipe.c | 8 +---
> drivers/net/ethernet/intel/ice/ice_lag.c | 5 +--
> drivers/net/ethernet/intel/ice/ice_main.c | 7 +---
> drivers/net/ethernet/intel/ice/ice_sriov.c | 3 +-
> 5 files changed, 19 insertions(+), 46 deletions(-)
>
very nice, thanks
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
next prev parent reply other threads:[~2024-06-05 4:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 22:13 [PATCH iwl-next v1 0/5] ice: add standard stats Jesse Brandeburg
2024-06-04 22:13 ` [PATCH iwl-next v1 1/5] net: docs: add missing features that can have stats Jesse Brandeburg
2024-06-04 22:19 ` Rahul Rameshbabu
2024-06-06 0:48 ` Jakub Kicinski
2024-06-06 16:28 ` Jesse Brandeburg
2024-06-06 16:56 ` Jacob Keller
2024-06-04 22:13 ` [PATCH iwl-next v1 2/5] ice: implement ethtool standard stats Jesse Brandeburg
2024-06-04 22:13 ` [PATCH iwl-next v1 3/5] ice: add tracking of good transmit timestamps Jesse Brandeburg
2024-06-04 22:13 ` [PATCH iwl-next v1 4/5] ice: implement transmit hardware timestamp statistics Jesse Brandeburg
2024-06-06 9:42 ` Hariprasad Kelam
2024-06-04 22:13 ` [PATCH iwl-next v1 5/5] ice: refactor to use helpers Jesse Brandeburg
2024-06-05 4:01 ` Przemek Kitszel [this message]
2024-06-06 0:50 ` [PATCH iwl-next v1 0/5] ice: add standard stats Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c19f080-8ad2-4e9a-b664-b5e3e45a852a@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=corbet@lwn.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).