From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH net-next 0/5] net: phy: improve and simplify phylib state machine Date: Wed, 7 Nov 2018 21:05:49 +0100 Message-ID: <5c2d1fba-0c94-210f-0d9b-e1d8f70fbee0@gmail.com> References: <922c223b-7bc0-e0ec-345d-2034b796af91@gmail.com> <20181107194816.GC9599@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" To: Andrew Lunn Return-path: Received: from mail-wr1-f66.google.com ([209.85.221.66]:35967 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725953AbeKHFhw (ORCPT ); Thu, 8 Nov 2018 00:37:52 -0500 Received: by mail-wr1-f66.google.com with SMTP id z13-v6so16388475wrs.3 for ; Wed, 07 Nov 2018 12:05:58 -0800 (PST) In-Reply-To: <20181107194816.GC9599@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07.11.2018 20:48, Andrew Lunn wrote: > On Wed, Nov 07, 2018 at 08:41:52PM +0100, Heiner Kallweit wrote: >> This patch series is based on two axioms: >> >> - During autoneg a PHY always reports the link being down > > Hi Heiner > > I think that is a risky assumption to make. > I wasn't sure initially too (found no clear rule in 802.3 clause 22) and therefore asked around. Florian agrees to the assumption, see here: https://www.spinics.net/lists/netdev/msg519242.html If a PHY reports the link as up then every user would assume that data can be transferred. But that's not the case during aneg. Therefore reporting the link as up during aneg wouldn't make sense. > What happens if this assumption is incorrect? > Then we have to flush this patch series down the drain ;) At least I would have to check in detail which parts need to be changed. I clearly mention the assumptions so that every reviewer can check whether he agrees. > Andrew > Heiner