From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: confusing comment, explanation of @IFF_RUNNING in if.h Date: Mon, 27 Aug 2018 09:11:58 +0200 Message-ID: <5c3004dc-e877-c142-60ac-91f4623e5153@hartkopp.net> References: <20180826192001.GC7359@lunn.ch> <20180826135144.11fd9a5f@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Linux kernel netdev mailing list To: "Robert P. J. Day" , Stephen Hemminger Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:27414 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbeH0LEX (ORCPT ); Mon, 27 Aug 2018 07:04:23 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 08/27/2018 08:20 AM, Robert P. J. Day wrote: > On Sun, 26 Aug 2018, Stephen Hemminger wrote: > >> On Sun, 26 Aug 2018 15:20:24 -0400 (EDT) >> "Robert P. J. Day" wrote: >> >>> On Sun, 26 Aug 2018, Andrew Lunn wrote: >>> >>>>> i ask since, in my testing, when the interface should have been >>>>> up, the attribute file "operstate" for that interface showed >>>>> "unknown", and i wondered how worried i should be about that. >>>> >>>> Hi Robert >>>> >>>> You should probably post the driver for review. A well written >>>> driver should not even need to care about any of this. phylib and >>>> the netdev driver code does all the work. It only gets interesting >>>> when you don't have a PHY, e.g. a stacked device, like bonding, or a >>>> virtual device like tun/tap. >>> >>> i wish, but i'm on contract, and proprietary, and NDA and all that. >>> so i am reduced to crawling through the code, trying to figure out >>> what is misconfigured that is causing all this grief. >>> >>> rday >>> >> >> So you expect FOSS developers to help you with proprietary licensed >> driver. Good Luck with that. > > sorry, i'm sure this will all be released upon production, just not > while it's in the midst of development. "released upon production" means usually: Oh, we put that driver in a tar-ball on a CD that's shipped with the product and which will get no further visibility nor (security) maintenance. Robert, please tell your manager that creating a driver is no rocket science and also brings no "costumer differentiation" which needs to be covered under NDA. Posting drivers and bring it into mainline Linux heavily increases the quality due to the review process and all the people that are willing to help you to get better. At the end your driver gets long-term maintenance and other people can benefit from it - as your boss is getting benefit from using Linux right now. When something is "released upon production" it will not be in a quality that it could go into the kernel - and no one will have the time/money/ambition to spend effort on it then. You have just produced one of the numerous dead out-of-tree drivers. That would be just sad. Best regards, Oliver