From: YanTeng Si <si.yanteng@linux.dev>
To: Simon Horman <horms@kernel.org>, Yanteng Si <siyanteng@loongson.cn>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
fancer.lancer@gmail.com, diasyzhang@tencent.com,
Jose.Abreu@synopsys.com, chenhuacai@kernel.org,
linux@armlinux.org.uk, guyinggang@loongson.cn,
netdev@vger.kernel.org, chris.chenfeiyang@gmail.com,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH net-next v16 12/14] net: stmmac: dwmac-loongson: Add Loongson Multi-channels GMAC support
Date: Wed, 7 Aug 2024 15:18:44 +0800 [thread overview]
Message-ID: <5c395c10-e3df-4880-9a22-371993a0806a@linux.dev> (raw)
In-Reply-To: <20240806151712.GX2636630@kernel.org>
在 2024/8/6 23:17, Simon Horman 写道:
> On Tue, Aug 06, 2024 at 07:00:22PM +0800, Yanteng Si wrote:
>
> ...
>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> ...
>
>> @@ -214,12 +532,15 @@ static void loongson_dwmac_remove(struct pci_dev *pdev)
>> {
>> struct net_device *ndev = dev_get_drvdata(&pdev->dev);
>> struct stmmac_priv *priv = netdev_priv(ndev);
>> + struct loongson_data *ld;
> minor nit: ld is not used in this patch or patchset; it can be removed
Thanks! I have let ld->loongson_id come back.
Thanks,
Yanteng
>
> ...
next prev parent reply other threads:[~2024-08-07 7:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 10:57 [PATCH net-next v16 00/14] stmmac: Add Loongson platform support Yanteng Si
2024-08-06 10:57 ` [PATCH net-next v16 01/14] net: stmmac: Move the atds flag to the stmmac_dma_cfg structure Yanteng Si
2024-08-06 10:57 ` [PATCH net-next v16 02/14] net: stmmac: Add multi-channel support Yanteng Si
2024-08-06 10:57 ` [PATCH net-next v16 03/14] net: stmmac: Export dwmac1000_dma_ops Yanteng Si
2024-08-06 10:58 ` [PATCH net-next v16 04/14] net: stmmac: dwmac-loongson: Drop duplicated hash-based filter size init Yanteng Si
2024-08-06 10:58 ` [PATCH net-next v16 05/14] net: stmmac: dwmac-loongson: Drop pci_enable/disable_msi calls Yanteng Si
2024-08-06 10:58 ` [PATCH net-next v16 06/14] net: stmmac: dwmac-loongson: Use PCI_DEVICE_DATA() macro for device identification Yanteng Si
2024-08-06 10:58 ` [PATCH net-next v16 07/14] net: stmmac: dwmac-loongson: Detach GMAC-specific platform data init Yanteng Si
2024-08-06 10:59 ` [PATCH net-next v16 08/14] net: stmmac: dwmac-loongson: Init ref and PTP clocks rate Yanteng Si
2024-08-06 10:59 ` [PATCH net-next v16 09/14] net: stmmac: dwmac-loongson: Add phy_interface for Loongson GMAC Yanteng Si
2024-08-06 10:59 ` [PATCH net-next v16 10/14] net: stmmac: dwmac-loongson: Introduce PCI device info data Yanteng Si
2024-08-06 10:59 ` [PATCH net-next v16 11/14] net: stmmac: dwmac-loongson: Add DT-less GMAC PCI-device support Yanteng Si
2024-08-06 19:10 ` Serge Semin
2024-08-07 7:19 ` YanTeng Si
2024-08-06 11:00 ` [PATCH net-next v16 12/14] net: stmmac: dwmac-loongson: Add Loongson Multi-channels GMAC support Yanteng Si
2024-08-06 15:17 ` Simon Horman
2024-08-07 7:18 ` YanTeng Si [this message]
2024-08-06 19:17 ` Serge Semin
2024-08-07 7:15 ` YanTeng Si
2024-08-06 11:00 ` [PATCH net-next v16 13/14] net: stmmac: dwmac-loongson: Add Loongson GNET support Yanteng Si
2024-08-06 11:00 ` [PATCH net-next v16 14/14] net: stmmac: dwmac-loongson: Add loongson module author Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c395c10-e3df-4880-9a22-371993a0806a@linux.dev \
--to=si.yanteng@linux.dev \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=diasyzhang@tencent.com \
--cc=fancer.lancer@gmail.com \
--cc=guyinggang@loongson.cn \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).