From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB763C43381 for ; Mon, 18 Feb 2019 16:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6E61214DA for ; Mon, 18 Feb 2019 16:25:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="GB2Z3T4o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389048AbfBRQZl (ORCPT ); Mon, 18 Feb 2019 11:25:41 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34476 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731987AbfBRQZl (ORCPT ); Mon, 18 Feb 2019 11:25:41 -0500 Received: by mail-pf1-f194.google.com with SMTP id u9so1561126pfn.1 for ; Mon, 18 Feb 2019 08:25:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lWYKzX1ixUcVH+E2g1IPndczpnP7fL4a67X9N3lX+Gk=; b=GB2Z3T4oyMv4UuCqQ3M74sQHazrRJ6Blu/vwMvB7hwhwXWYbB6U9ag7OWjpmLDkn3P QCdzgnSxNlWNHFIjvHDeMPbA+dZQQLEW7SvkEOLoBTvcOC5yBXcqOlbNYo9/0eyIoZZU pR8QVC0zYsFnP9kP9U9afXZKZcbJwgyImI4V0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lWYKzX1ixUcVH+E2g1IPndczpnP7fL4a67X9N3lX+Gk=; b=URB1cLliwFpuIi2k/Reg5u5rGJ8KuWjvpsKL1bRAUM5K7gh9R7WdOyYbYlTeXG5lLQ FVAKaY5zA3c79mwNPBAYuBbULZZrU/KDelLkYJyGdOf5akhveYkEkpTa/2lbC/DWTQBu OwG1kM+WwHpWuhjQTWb0Xs/8te2lqz9S7hVizjhCJqtdNug+yTczxWoPWzF0gbmE4Dlg ZwkN1zvJFNfwftI0ibesy+fDqoJNuC3gt/AxpURXvnRVwH/WZUsswd5rAXuZKoE7OV0O OUQ9kYPrka0T44pARW1sNxsFuziBqjEUZ3dSTbrcEOtBJv041pF7z+AmqnE8yIyQAbBq 09/w== X-Gm-Message-State: AHQUAuaO/923PjsQhDd0iiXvWerIU9D+G+R/t9gLH+T8dCEzRK14eWpI BsJLO2x1DvRLJ3iGRfAF15Yokg== X-Google-Smtp-Source: AHgI3IaekuLgHbawgvt7y+2+k8VR+7Xvijsm1kPNbjVNWDejiz4GSSCjnGcu5e/jVZCpqfq5597PXw== X-Received: by 2002:a62:4188:: with SMTP id g8mr25647037pfd.205.1550507140550; Mon, 18 Feb 2019 08:25:40 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:7c6e:8868:2f8f:ef22? ([2601:282:800:fd80:7c6e:8868:2f8f:ef22]) by smtp.googlemail.com with ESMTPSA id l87sm35542711pfj.35.2019.02.18.08.25.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 08:25:39 -0800 (PST) Subject: Re: [net PATCH] net: vrf: remove MTU limits for vrf device To: Hangbin Liu , netdev@vger.kernel.org Cc: "David S . Miller" , Davide Caratti References: <20190218091425.11067-1-liuhangbin@gmail.com> From: David Ahern Message-ID: <5c3ed35a-9690-e4e2-7682-8b517d0f1921@cumulusnetworks.com> Date: Mon, 18 Feb 2019 09:25:37 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190218091425.11067-1-liuhangbin@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/18/19 2:14 AM, Hangbin Liu wrote: > Similiar to commit e94cd8113ce63 ("net: remove MTU limits for dummy and > ifb device"), MTU is irrelevant for VRF device. We init it as 64K while > limit it to [68, 1500] may make users feel confused. > > Reported-by: Jianlin Shi > Signed-off-by: Hangbin Liu > --- > drivers/net/vrf.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c > index 95909e262ba4..7c1430ed0244 100644 > --- a/drivers/net/vrf.c > +++ b/drivers/net/vrf.c > @@ -1273,6 +1273,9 @@ static void vrf_setup(struct net_device *dev) > > /* default to no qdisc; user can add if desired */ > dev->priv_flags |= IFF_NO_QUEUE; > + > + dev->min_mtu = 0; > + dev->max_mtu = 0; > } > > static int vrf_validate(struct nlattr *tb[], struct nlattr *data[], > Reviewed-by: David Ahern