From: Roi Dayan <roid@mellanox.com>
To: Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
Saeed Mahameed <saeedm@mellanox.com>,
"leon@kernel.org" <leon@kernel.org>, mlxsw <mlxsw@mellanox.com>
Subject: Re: [patch net-next v2] mlx5: Add missing init_net check in FIB notifier
Date: Sun, 1 Sep 2019 07:38:00 +0000 [thread overview]
Message-ID: <5c5379ea-1d3c-6e02-e100-b67bd0effb1f@mellanox.com> (raw)
In-Reply-To: <20190830082530.8958-1-jiri@resnulli.us>
On 2019-08-30 11:25 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Take only FIB events that are happening in init_net into account. No other
> namespaces are supported.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> v1->v2:
> - no change, just cced maintainers (fat finger made me avoid them in v1)
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
> index e69766393990..5d20d615663e 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
> @@ -248,6 +248,9 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
> struct net_device *fib_dev;
> struct fib_info *fi;
>
> + if (!net_eq(info->net, &init_net))
> + return NOTIFY_DONE;
> +
> if (info->family != AF_INET)
> return NOTIFY_DONE;
>
>
thanks
Acked-by: Roi Dayan <roid@mellanox.com>
next prev parent reply other threads:[~2019-09-01 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 8:25 [patch net-next v2] mlx5: Add missing init_net check in FIB notifier Jiri Pirko
2019-09-01 7:38 ` Roi Dayan [this message]
2019-09-02 18:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c5379ea-1d3c-6e02-e100-b67bd0effb1f@mellanox.com \
--to=roid@mellanox.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox