From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039A1C76186 for ; Tue, 23 Jul 2019 23:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3834216F4 for ; Tue, 23 Jul 2019 23:21:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="RH9S6noB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726675AbfGWXVS (ORCPT ); Tue, 23 Jul 2019 19:21:18 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:39643 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbfGWXVS (ORCPT ); Tue, 23 Jul 2019 19:21:18 -0400 Received: by mail-lf1-f68.google.com with SMTP id v85so30515497lfa.6 for ; Tue, 23 Jul 2019 16:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6VcnojKIbtzJpkTGh7+taUptRhWCxNbM28ufXgjHO8Y=; b=RH9S6noB1vvpjAeNSbPRoxIRiPWap+AY7DIyq8HlA7WpIVBAXfssyLflGxrBYznvmV aLhvMFz/4eNG+XCDP0JgkdeVQ7CikA1IN8feem7vM5zS/3B6OMVG92tY5vHiBNDw1tL2 7T+QE4MP9irbPiWYe4LR7r5VTc71xqfQPJfBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6VcnojKIbtzJpkTGh7+taUptRhWCxNbM28ufXgjHO8Y=; b=cwIHOeW0MdT57hBGYtjjn8W04OhsOmMPgq4fLVmwj4sOu7+PpVumaUbVPe+dC3FFt2 qrxKp6oN7ytZMM4ilvzzWSAyW8fEVN4dXvrdlNE10Cf3bN8S3O9ZTeV1AL0hhnom+JF8 G5f0k5Swpbaxc0uh/s5ngx8q6oYtU1bASwxYrovgCnb8nmUPclyI7Mleiwnt01ixUTaD z7mo9FfD3tt1jKbKNOXUZw3YwRhzOEEzxEJXD2SAiEfnS6hBOyx20fIcHBMXUp7J3NXf VoZtkl9L5/sdxi5anIau/VJ1/PAKJ1hDVtgXu1T+tKNJE1cNlmAzGWw47pDvoKVg4bP7 ngQA== X-Gm-Message-State: APjAAAV79DRaAZKZ/2zXSijdfusD8gXj7sYs1UieDRdZM2SRMDJ2dSxJ D4llMT0hTA8LRz9owB9BvIJ31MLObqU= X-Google-Smtp-Source: APXvYqyZtmD5WVvtMvQnvqmhXb35VjkZOtmG0KdZqRRzM2cQY34rRX0AjeVW0X9KA2zKuYlEV4qhJg== X-Received: by 2002:ac2:48bc:: with SMTP id u28mr24733951lfg.126.1563924075380; Tue, 23 Jul 2019 16:21:15 -0700 (PDT) Received: from [192.168.0.109] (84-238-136-197.ip.btc-net.bg. [84.238.136.197]) by smtp.googlemail.com with ESMTPSA id u13sm6727538lfu.37.2019.07.23.16.21.14 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jul 2019 16:21:14 -0700 (PDT) Subject: Re: [PATCH] fix noderef.cocci warnings To: kbuild test robot Cc: kbuild-all@01.org, Martin Weinelt , bridge@lists.linux-foundation.org, Roopa Prabhu , netdev@vger.kernel.org References: <908e9e90-70cc-7bbe-f83f-0810c9ef3925@cumulusnetworks.com> <20190723225458.GA3376@lkp-kbuild04> From: Nikolay Aleksandrov Message-ID: <5c5eaeee-dfaa-d75e-8ece-a72c7ff467ec@cumulusnetworks.com> Date: Wed, 24 Jul 2019 02:21:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190723225458.GA3376@lkp-kbuild04> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/24/19 1:54 AM, kbuild test robot wrote: > From: kbuild test robot > > net/bridge/br_multicast.c:999:8-14: ERROR: application of sizeof to pointer > > sizeof when applied to a pointer typed expression gives the size of > the pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > Fixes: 17c91348ed8b ("Use-after-free in br_multicast_rcv") > CC: Nikolay Aleksandrov > Signed-off-by: kbuild test robot > --- > > url: https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-fix-possible-uses-of-stale-pointers/20190702-083354 > > br_multicast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/net/bridge/br_multicast.c > +++ b/net/bridge/br_multicast.c > @@ -996,7 +996,7 @@ static int br_ip6_multicast_mld2_report( > return -EINVAL; > > _nsrcs = skb_header_pointer(skb, nsrcs_offset, > - sizeof(_nsrcs), &__nsrcs); > + sizeof(*_nsrcs), &__nsrcs); > if (!_nsrcs) > return -EINVAL; > > This must be quite old, I already sent a proper patch without this error. This one was sent just for testing, hence the TEST in $subject. [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers Thanks, Nik