From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
nbd@nbd.name, hkallweit1@gmail.com, sgruszka@redhat.com,
lorenzo.bianconi@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3 wireless-drivers 0/2] fix mt76x2e hangs on U7612E mini-pcie
Date: Mon, 28 Oct 2019 08:17:02 +0100 [thread overview]
Message-ID: <5c6bdfd65ae3178cff2f55233e9e8465@natalenko.name> (raw)
In-Reply-To: <cover.1572204430.git.lorenzo@kernel.org>
On 27.10.2019 20:53, Lorenzo Bianconi wrote:
> Various mt76x2e issues have been reported on U7612E mini-pcie card [1].
> On U7612E-H1 PCIE_ASPM causes continuous mcu hangs and instability and
> so patch 1/2 disable it by default.
> Moreover mt76 does not properly unmap dma buffers for non-linear skbs.
> This issue may result in hw hangs if the system relies on IOMMU.
> Patch 2/2 fix the problem properly unmapping data fragments on
> non-linear skbs.
>
> Changes since v2:
> - fix compilation error if PCI support is not compiled
>
> Changes since v1:
> - simplify buf0 unmap condition
> - use IS_ENABLED(CONFIG_PCIEASPM) instead of ifdef CONFIG_PCIEASPM
> - check pci_disable_link_state return value
>
> [1]:
> https://lore.kernel.org/netdev/deaafa7a3e9ea2111ebb5106430849c6@natalenko.name/
>
>
> Lorenzo Bianconi (2):
> mt76: mt76x2e: disable pcie_aspm by default
> mt76: dma: fix buffer unmap with non-linear skbs
>
> drivers/net/wireless/mediatek/mt76/Makefile | 2 +
> drivers/net/wireless/mediatek/mt76/dma.c | 6 ++-
> drivers/net/wireless/mediatek/mt76/mt76.h | 6 ++-
> .../net/wireless/mediatek/mt76/mt76x2/pci.c | 2 +
> drivers/net/wireless/mediatek/mt76/pci.c | 46 +++++++++++++++++++
> 5 files changed, 58 insertions(+), 4 deletions(-)
> create mode 100644 drivers/net/wireless/mediatek/mt76/pci.c
So, works fine for me. Checked with 5.3 and additional include fix I've
mentioned previously.
With that, for the whole series feel free to add:
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Thank you.
--
Oleksandr Natalenko (post-factum)
prev parent reply other threads:[~2019-10-28 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 19:53 [PATCH v3 wireless-drivers 0/2] fix mt76x2e hangs on U7612E mini-pcie Lorenzo Bianconi
2019-10-27 19:53 ` [PATCH v3 wireless-drivers 1/2] mt76: mt76x2e: disable pcie_aspm by default Lorenzo Bianconi
2019-10-27 21:40 ` Oleksandr Natalenko
2019-10-30 15:00 ` Kalle Valo
2019-10-27 19:53 ` [PATCH v3 wireless-drivers 2/2] mt76: dma: fix buffer unmap with non-linear skbs Lorenzo Bianconi
2019-10-28 7:17 ` Oleksandr Natalenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c6bdfd65ae3178cff2f55233e9e8465@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=hkallweit1@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).