From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Florian Klink <flokli@flokli.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Kim Phillips <kim.phillips@arm.com>
Subject: Re: [PATCH] ipv4: use IS_ENABLED instead of ifdef
Date: Tue, 17 Nov 2020 17:55:54 -0700 [thread overview]
Message-ID: <5cbc79c3-0a66-8cfb-64f4-399aab525d09@gmail.com> (raw)
In-Reply-To: <20201117160110.42aa3b72@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On 11/17/20 5:01 PM, Jakub Kicinski wrote:
> On Sun, 15 Nov 2020 23:45:09 +0100 Florian Klink wrote:
>> Checking for ifdef CONFIG_x fails if CONFIG_x=m.
>>
>> Use IS_ENABLED instead, which is true for both built-ins and modules.
>>
>> Otherwise, a
>>> ip -4 route add 1.2.3.4/32 via inet6 fe80::2 dev eth1
>> fails with the message "Error: IPv6 support not enabled in kernel." if
>> CONFIG_IPV6 is `m`.
>>
>> In the spirit of b8127113d01e53adba15b41aefd37b90ed83d631.
>>
>> Cc: Kim Phillips <kim.phillips@arm.com>
>> Signed-off-by: Florian Klink <flokli@flokli.de>
>
> LGTM, this is the fixes tag right?
>
> Fixes: d15662682db2 ("ipv4: Allow ipv6 gateway with ipv4 routes")
yep.
>
> CCing David to give him a chance to ack.
Reviewed-by: David Ahern <dsahern@kernel.org>
I looked at this yesterday and got distracted diving into the generated
file to see the difference:
#define CONFIG_IPV6 1
vs
#define CONFIG_IPV6_MODULE 1
next prev parent reply other threads:[~2020-11-18 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 22:45 [PATCH] ipv4: use IS_ENABLED instead of ifdef Florian Klink
2020-11-18 0:01 ` Jakub Kicinski
2020-11-18 0:55 ` David Ahern [this message]
2020-11-18 1:07 ` Jakub Kicinski
2020-11-18 3:09 ` Randy Dunlap
2020-11-18 8:51 ` Florian Klink
2020-11-18 16:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cbc79c3-0a66-8cfb-64f4-399aab525d09@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=flokli@flokli.de \
--cc=kim.phillips@arm.com \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox