From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCA4C10F0E for ; Sun, 7 Apr 2019 10:12:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CE692087F for ; Sun, 7 Apr 2019 10:12:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jv22Ip8u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726123AbfDGKLm (ORCPT ); Sun, 7 Apr 2019 06:11:42 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36693 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfDGKLl (ORCPT ); Sun, 7 Apr 2019 06:11:41 -0400 Received: by mail-wm1-f65.google.com with SMTP id h18so11548730wml.1 for ; Sun, 07 Apr 2019 03:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=X19Y6piz+J6TEzYWIticK5PgFem5Pp1mxKFPPyA+reU=; b=jv22Ip8ui2p3yqmKuLZ4UhWTbuB9HGksskhL2N8P/IbmlR4QC+Fa+Kr3o0AF3MC9oS leYBnP/Q3/VoiATjqna1DnGX5GJexixtdbJLJxE7mp3bp9XIjdSx2kma3VS5WT81aXpy Uog5JsCPqBS9LfElULnDqYmdE+1JTXKOKp0NHkDsmJjYXmVzOQf4hWJvZ6wNWcZByafD HuDXyjZqYkvyYN/Io77E/YorHAugR23PN//+UmWGFbg57RE640AjP+RoipF9yAOz2tSN /ihCx8rcA6tkWYNufB5na2lUCfgj6xzkbL7A4UzRj4QxkZ+ucDcf1RUeArv9bn6mFlrp 8pmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=X19Y6piz+J6TEzYWIticK5PgFem5Pp1mxKFPPyA+reU=; b=IrZzekHzjSBc1gt4L5N0o7akG3Wztt1iKzt/IhFuXS9gmq2qLS4ZePyK73wi/Xbu9K 7QQb+OMbIQWwzqSGjZ15VdqjNO2n3VOMw6u8H9T8uMm9ZN7uXwBu3W2lq+c3xpTR3N5d tvZ60dU1kcqlegYFtI5BuizoCrfrtJiIvEfjvgcIXkrqg+AsK/2ExrWEusD4b/NWBVxg tbyEUBBdUA3vtwVbp71Cg4TCVdKwx7FvYYRwMwNNDVoOBBrlAoysMhdKsggJ8SyDPQA1 gpxvVvPf/GM9/vlMWZIO0K4nJdDo4SWF2Jl0w8Ors+n5s+cDaKygnU/Xe++d0gXq5WlJ +eKQ== X-Gm-Message-State: APjAAAUXk5RMnfDB+tmNCsbBMm6m0NCY7CvAxQ1ztKm2KMYOhyHQflzS 1XNsKqCfuXKGX9tq60JplQbpDsLK X-Google-Smtp-Source: APXvYqzrGgTjp68Jdr8pvMJyGQllVPuXL0mBurr2j6qKwqS8Zm/Df9LHYnJiKnxhspaKlS8iHAf69g== X-Received: by 2002:a1c:5f06:: with SMTP id t6mr14419739wmb.7.1554631899851; Sun, 07 Apr 2019 03:11:39 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:cd3d:7432:4830:ab0a? (p200300EA8BE1DD00CD3D74324830AB0A.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:cd3d:7432:4830:ab0a]) by smtp.googlemail.com with ESMTPSA id v17sm6365248wmc.30.2019.04.07.03.11.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Apr 2019 03:11:39 -0700 (PDT) To: Andrew Lunn , Florian Fainelli , David Miller , Russell King Cc: "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net-next] net: phy: remove unnecessary callback settings in C45 drivers Message-ID: <5cc623bf-1d73-3de6-d78e-acedc40c1471@gmail.com> Date: Sun, 7 Apr 2019 12:11:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org genphy_c45_aneg_done() is used by phylib as fallback for c45 PHY's if callback aneg_done isn't defined. So we don't have to set this explicitly. Same for genphy_c45_pma_read_abilities(). Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia_main.c | 14 -------------- drivers/net/phy/marvell10g.c | 1 - 2 files changed, 15 deletions(-) diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c index b7133c3f7..eed4fe3d8 100644 --- a/drivers/net/phy/aquantia_main.c +++ b/drivers/net/phy/aquantia_main.c @@ -598,8 +598,6 @@ static struct phy_driver aqr_driver[] = { { PHY_ID_MATCH_MODEL(PHY_ID_AQ1202), .name = "Aquantia AQ1202", - .aneg_done = genphy_c45_aneg_done, - .get_features = genphy_c45_pma_read_abilities, .config_aneg = aqr_config_aneg, .config_intr = aqr_config_intr, .ack_interrupt = aqr_ack_interrupt, @@ -608,8 +606,6 @@ static struct phy_driver aqr_driver[] = { { PHY_ID_MATCH_MODEL(PHY_ID_AQ2104), .name = "Aquantia AQ2104", - .aneg_done = genphy_c45_aneg_done, - .get_features = genphy_c45_pma_read_abilities, .config_aneg = aqr_config_aneg, .config_intr = aqr_config_intr, .ack_interrupt = aqr_ack_interrupt, @@ -618,8 +614,6 @@ static struct phy_driver aqr_driver[] = { { PHY_ID_MATCH_MODEL(PHY_ID_AQR105), .name = "Aquantia AQR105", - .aneg_done = genphy_c45_aneg_done, - .get_features = genphy_c45_pma_read_abilities, .config_aneg = aqr_config_aneg, .config_intr = aqr_config_intr, .ack_interrupt = aqr_ack_interrupt, @@ -628,8 +622,6 @@ static struct phy_driver aqr_driver[] = { { PHY_ID_MATCH_MODEL(PHY_ID_AQR106), .name = "Aquantia AQR106", - .aneg_done = genphy_c45_aneg_done, - .get_features = genphy_c45_pma_read_abilities, .config_aneg = aqr_config_aneg, .config_intr = aqr_config_intr, .ack_interrupt = aqr_ack_interrupt, @@ -638,8 +630,6 @@ static struct phy_driver aqr_driver[] = { { PHY_ID_MATCH_MODEL(PHY_ID_AQR107), .name = "Aquantia AQR107", - .aneg_done = genphy_c45_aneg_done, - .get_features = genphy_c45_pma_read_abilities, .probe = aqr107_probe, .config_init = aqr107_config_init, .config_aneg = aqr_config_aneg, @@ -658,8 +648,6 @@ static struct phy_driver aqr_driver[] = { { PHY_ID_MATCH_MODEL(PHY_ID_AQCS109), .name = "Aquantia AQCS109", - .aneg_done = genphy_c45_aneg_done, - .get_features = genphy_c45_pma_read_abilities, .probe = aqr107_probe, .config_init = aqcs109_config_init, .config_aneg = aqr_config_aneg, @@ -678,8 +666,6 @@ static struct phy_driver aqr_driver[] = { { PHY_ID_MATCH_MODEL(PHY_ID_AQR405), .name = "Aquantia AQR405", - .aneg_done = genphy_c45_aneg_done, - .get_features = genphy_c45_pma_read_abilities, .config_aneg = aqr_config_aneg, .config_intr = aqr_config_intr, .ack_interrupt = aqr_ack_interrupt, diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c index fc06e8c9a..238a20e13 100644 --- a/drivers/net/phy/marvell10g.c +++ b/drivers/net/phy/marvell10g.c @@ -482,7 +482,6 @@ static struct phy_driver mv3310_drivers[] = { .phy_id = MARVELL_PHY_ID_88E2110, .phy_id_mask = MARVELL_PHY_ID_MASK, .name = "mv88x2110", - .get_features = genphy_c45_pma_read_abilities, .probe = mv3310_probe, .suspend = mv3310_suspend, .resume = mv3310_resume, -- 2.21.0