From: David Ahern <dsahern@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Quentin Monnet <quentin.monnet@netronome.com>
Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf-next 2/3] bpf: fix formatting for bpf_get_stack() helper doc
Date: Mon, 30 Apr 2018 09:12:27 -0600 [thread overview]
Message-ID: <5cc7a2d9-2a76-c323-e607-2b0400758297@gmail.com> (raw)
In-Reply-To: <20180430150833.gt2di56f4jembb2f@ast-mbp.dhcp.thefacebook.com>
On 4/30/18 9:08 AM, Alexei Starovoitov wrote:
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index 530ff6588d8f..8daef7326bb7 100644
>> --- a/include/uapi/linux/bpf.h
>> +++ b/include/uapi/linux/bpf.h
>> @@ -1770,33 +1770,33 @@ union bpf_attr {
>> *
>> * int bpf_get_stack(struct pt_regs *regs, void *buf, u32 size, u64 flags)
>> * Description
>> - * Return a user or a kernel stack in bpf program provided buffer.
>> - * To achieve this, the helper needs *ctx*, which is a pointer
>> + * Return a user or a kernel stack in bpf program provided buffer.
>> + * To achieve this, the helper needs *ctx*, which is a pointer
>
> I still don't quite get the difference.
> It's replacing 2 tabs in above with 1 space + 2 tabs ?
> Can you please teach the python script to accept both?
> I bet that will be recurring mistake and it's impossible to spot in code review.
>
And checkpatch throws an error on the 1 space + 2 tabs so it gets
confusing on which format should be used.
next prev parent reply other threads:[~2018-04-30 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 10:39 [PATCH bpf-next 0/3] bpf: fix formatting for eBPF helper doc Quentin Monnet
2018-04-30 10:39 ` [PATCH bpf-next 1/3] bpf: fix formatting for bpf_perf_event_read() " Quentin Monnet
2018-04-30 10:39 ` [PATCH bpf-next 2/3] bpf: fix formatting for bpf_get_stack() " Quentin Monnet
2018-04-30 15:08 ` Alexei Starovoitov
2018-04-30 15:12 ` David Ahern [this message]
2018-04-30 15:16 ` Quentin Monnet
2018-04-30 10:39 ` [PATCH bpf-next 3/3] bpf: update bpf.h uapi header for tools Quentin Monnet
2018-04-30 11:57 ` [PATCH bpf-next 0/3] bpf: fix formatting for eBPF helper doc Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cc7a2d9-2a76-c323-e607-2b0400758297@gmail.com \
--to=dsahern@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).