From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH bpf-next 2/3] bpf: fix formatting for bpf_get_stack() helper doc Date: Mon, 30 Apr 2018 09:12:27 -0600 Message-ID: <5cc7a2d9-2a76-c323-e607-2b0400758297@gmail.com> References: <20180430103905.12863-1-quentin.monnet@netronome.com> <20180430103905.12863-3-quentin.monnet@netronome.com> <20180430150833.gt2di56f4jembb2f@ast-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, Yonghong Song To: Alexei Starovoitov , Quentin Monnet Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:37657 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754093AbeD3PMe (ORCPT ); Mon, 30 Apr 2018 11:12:34 -0400 Received: by mail-pf0-f194.google.com with SMTP id e9so2978574pfi.4 for ; Mon, 30 Apr 2018 08:12:34 -0700 (PDT) In-Reply-To: <20180430150833.gt2di56f4jembb2f@ast-mbp.dhcp.thefacebook.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/30/18 9:08 AM, Alexei Starovoitov wrote: >> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >> index 530ff6588d8f..8daef7326bb7 100644 >> --- a/include/uapi/linux/bpf.h >> +++ b/include/uapi/linux/bpf.h >> @@ -1770,33 +1770,33 @@ union bpf_attr { >> * >> * int bpf_get_stack(struct pt_regs *regs, void *buf, u32 size, u64 flags) >> * Description >> - * Return a user or a kernel stack in bpf program provided buffer. >> - * To achieve this, the helper needs *ctx*, which is a pointer >> + * Return a user or a kernel stack in bpf program provided buffer. >> + * To achieve this, the helper needs *ctx*, which is a pointer > > I still don't quite get the difference. > It's replacing 2 tabs in above with 1 space + 2 tabs ? > Can you please teach the python script to accept both? > I bet that will be recurring mistake and it's impossible to spot in code review. > And checkpatch throws an error on the 1 space + 2 tabs so it gets confusing on which format should be used.