From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Ma Ke <make24@iscas.ac.cn>,
yoshihiro.shimoda.uh@renesas.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, niklas.soderlund+renesas@ragnatech.se,
michael.dege@renesas.com, yury.norov@gmail.com,
geert+renesas@glider.be
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] net: renesas: rswitch: Fix memory leak in rswitch_phy_device_init()
Date: Mon, 30 Mar 2026 09:59:18 +0200 [thread overview]
Message-ID: <5cf41f14-e694-4b06-8b82-1d98238758d4@cogentembedded.com> (raw)
In-Reply-To: <20260330073541.2871414-1-make24@iscas.ac.cn>
> - phydev = of_phy_find_device(phy);
> - if (!phydev)
> + tmp_phydev = of_phy_find_device(phy);
> + if (!tmp_phydev)
> goto out;
> - __set_bit(rdev->etha->phy_interface, phydev->host_interfaces);
> + __set_bit(rdev->etha->phy_interface, tmp_phydev->host_interfaces);
> phydev->mac_managed_pm = true;
shall be tmp_phydev ?
next prev parent reply other threads:[~2026-03-30 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 7:35 [PATCH] net: renesas: rswitch: Fix memory leak in rswitch_phy_device_init() Ma Ke
2026-03-30 7:59 ` Nikita Yushchenko [this message]
2026-03-30 22:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf41f14-e694-4b06-8b82-1d98238758d4@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox