From: "Nazle Asmade, Muhammad Nazim Amirul" <muhammad.nazim.amirul.nazle.asmade@altera.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: stmmac: Add support for TX/RX channel interrupt
Date: Tue, 5 May 2026 02:57:25 +0000 [thread overview]
Message-ID: <5d2b7cfb-a4db-45c0-b92b-fe16b9d5df40@altera.com> (raw)
In-Reply-To: <42b173da-5c0b-4d72-9247-49ebec5e95e5@lunn.ch>
On 1/5/2026 4:53 am, Andrew Lunn wrote:
> [You don't often get email from andrew@lunn.ch. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
>> + /* For RX Channel */
>> + for (i = 0; i < MTL_MAX_RX_QUEUES; i++) {
>> + snprintf(irq_name, sizeof(irq_name), "dma_rx%i", i);
>> + irq = platform_get_irq_byname_optional(pdev, irq_name);
>> + if (irq == -EPROBE_DEFER)
>> + return irq;
>> + else if (irq < 0)
>> + break;
>
> It would be good to differentiate between real errors, and it not
> being available. I think -ENOXIO is returned when it does not
> exist. Anything else is a real error?
>
> Andrew
comment have been addressed and updated in v2
https://lore.kernel.org/all/20260505024459.22463-1-muhammad.nazim.amirul.nazle.asmade@altera.com/
Nazim
prev parent reply other threads:[~2026-05-05 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 7:27 [PATCH] net: stmmac: Add support for TX/RX channel interrupt muhammad.nazim.amirul.nazle.asmade
2026-04-30 20:53 ` Andrew Lunn
2026-05-05 2:57 ` Nazle Asmade, Muhammad Nazim Amirul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d2b7cfb-a4db-45c0-b92b-fe16b9d5df40@altera.com \
--to=muhammad.nazim.amirul.nazle.asmade@altera.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox