From: David Ahern <dsahern@gmail.com>
To: Harald Welte <laforge@gnumonks.org>,
"Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next v5 1/2] ip: GTP support in ip link
Date: Thu, 17 Mar 2022 08:47:48 -0600 [thread overview]
Message-ID: <5d2d7c77-2c08-7c6e-b816-bbab21c36171@gmail.com> (raw)
In-Reply-To: <YjM/jXnaCDaBrTNX@nataraja>
On 3/17/22 8:02 AM, Harald Welte wrote:
> Hi Wojciech, David,
>
> On Thu, Mar 17, 2022 at 11:11:40AM +0000, Drewek, Wojciech wrote:
>>> as a u32 does that mean more roles might get added? Seems like this
>>> should have a attr to string converter that handles future additions.
>>
>> I think no more roles are expected but we can ask Harald.
>
> I also don't currently know of any situation where we would want to add
> more roles.
>
Better safe than giving users wrong information. I would prefer if this
attribute to string conversion handle the 2 known roles and return
"unknown" if a new value pops up.
next prev parent reply other threads:[~2022-03-17 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 11:08 [PATCH iproute2-next v5 0/2] GTP support for ip link and tc flowers Wojciech Drewek
2022-03-16 11:08 ` [PATCH iproute2-next v5 1/2] ip: GTP support in ip link Wojciech Drewek
2022-03-17 0:56 ` David Ahern
2022-03-17 11:11 ` Drewek, Wojciech
2022-03-17 14:02 ` Harald Welte
2022-03-17 14:47 ` David Ahern [this message]
2022-03-17 16:11 ` Drewek, Wojciech
2022-03-16 11:08 ` [PATCH iproute2-next v5 2/2] f_flower: Implement gtp options support Wojciech Drewek
2022-03-17 0:58 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d2d7c77-2c08-7c6e-b816-bbab21c36171@gmail.com \
--to=dsahern@gmail.com \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).