From: David Ahern <dsahern@gmail.com>
To: David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net
Cc: brak@choopa.com
Subject: Re: [PATCH net] ipv6: fib6_select_path can not use out path for nexthop objects
Date: Mon, 6 Jul 2020 11:34:12 -0600 [thread overview]
Message-ID: <5d2deb19-3c7d-5db1-23c8-4f8d15594089@gmail.com> (raw)
In-Reply-To: <20200706171908.18222-1-dsahern@kernel.org>
On 7/6/20 11:19 AM, David Ahern wrote:
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 82cbb46a2a4f..6451ba313506 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -431,7 +431,7 @@ void fib6_select_path(const struct net *net, struct fib6_result *res,
> struct fib6_info *sibling, *next_sibling;
> struct fib6_info *match = res->f6i;
>
> - if ((!match->fib6_nsiblings && !match->nh) || have_oif_match)
> + if (!match->nh && (!match->fib6_nsiblings || have_oif_match))
> goto out;
>
> /* We might have already computed the hash for ICMPv6 errors. In such
of course I notice this after sending the patch. This can actually break
with multipath nexthop objects since it can overwrite the selected path
if done earlier.
DaveM: please drop; will send a v2
prev parent reply other threads:[~2020-07-06 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 17:19 [PATCH net] ipv6: fib6_select_path can not use out path for nexthop objects David Ahern
2020-07-06 17:34 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d2deb19-3c7d-5db1-23c8-4f8d15594089@gmail.com \
--to=dsahern@gmail.com \
--cc=brak@choopa.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox