From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch
Subject: Re: [PATCH net-next 3/4] net: phy: sfp: Separate enumerations and states
Date: Thu, 9 Nov 2017 20:40:41 -0800 [thread overview]
Message-ID: <5d42cec6-bf8c-d3b7-2c4e-ee3a66711cc2@gmail.com> (raw)
In-Reply-To: <20171108085804.GP9463@n2100.armlinux.org.uk>
On 11/08/2017 12:58 AM, Russell King - ARM Linux wrote:
> On Tue, Nov 07, 2017 at 07:49:10PM -0800, Florian Fainelli wrote:
>> Create separate enumerations for the SFP physical state (computed from GPIOs),
>> device state, module state, and actual state machine. This will make it easier
>> to make sure the correct states are used, and also pretty print those to help
>> debugging.
>
> The compiler does no type checking of these, so I don't see how it
> makes it any "easier to make sure the correct states are used".
The types currently used (unsigned char, unsigned short) do not make it
easy to spot what the enumeration is about and what values could be
valid. Overall it seems to me like this improves code readability if
nothing else.
--
Florian
next prev parent reply other threads:[~2017-11-10 4:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 3:49 [PATCH net-next 0/4] net: phy: sfp: Fixes and debugging improvements Florian Fainelli
2017-11-08 3:49 ` [PATCH net-next 1/4] net: phy: sfp: Do not reject soldered down modules Florian Fainelli
2017-11-08 11:15 ` Russell King - ARM Linux
2017-11-10 4:39 ` Florian Fainelli
2017-11-08 3:49 ` [PATCH net-next 2/4] net: phy: sfp: Use correct endian for sfp->id.ext.options Florian Fainelli
2017-11-08 8:56 ` Russell King - ARM Linux
2017-11-10 4:39 ` Florian Fainelli
2017-11-08 3:49 ` [PATCH net-next 3/4] net: phy: sfp: Separate enumerations and states Florian Fainelli
2017-11-08 8:58 ` Russell King - ARM Linux
2017-11-10 4:40 ` Florian Fainelli [this message]
2017-11-08 3:49 ` [PATCH net-next 4/4] net: phy: sfp: Pretty print state machine events Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d42cec6-bf8c-d3b7-2c4e-ee3a66711cc2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).