netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add mac resource support for w90p910
@ 2009-07-16 12:49 Wan ZongShun
  2009-07-16 13:09 ` Trilok Soni
  0 siblings, 1 reply; 4+ messages in thread
From: Wan ZongShun @ 2009-07-16 12:49 UTC (permalink / raw)
  To: David S. Miller, linux-netdev, linux-arm-kernel, Russell King,
	"Er

Dear Russell,

This is a mac resource define for my MAC driver for w90p910 platform.

thanks!

Add mac resource support for w90p910 mac driver

Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
---
 arch/arm/mach-w90x900/mach-w90p910evb.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-w90x900/mach-w90p910evb.c b/arch/arm/mach-w90x900/mach-w90p910evb.c
index 7a62bd3..06e1155 100644
--- a/arch/arm/mach-w90x900/mach-w90p910evb.c
+++ b/arch/arm/mach-w90x900/mach-w90p910evb.c
@@ -228,6 +228,33 @@ struct platform_device w90x900_device_usbgadget = {
 };
 EXPORT_SYMBOL(w90x900_device_usbgadget);
 
+/* EMC Device */
+
+static struct resource w90x900_emc_resource[] = {
+	[0] = {
+		.start = W90X900_PA_EMC,
+		.end   = W90X900_PA_EMC + W90X900_SZ_EMC - 1,
+		.flags = IORESOURCE_MEM,
+	},
+	[1] = {
+		.start = IRQ_EMCTX,
+		.end   = IRQ_EMCTX,
+		.flags = IORESOURCE_IRQ,
+	},
+	[2] = {
+		.start = IRQ_EMCRX,
+		.end   = IRQ_EMCRX,
+		.flags = IORESOURCE_IRQ,
+	}
+};
+
+struct platform_device w90p910_device_emc = {
+	.name		= "w90p910-emc",
+	.id		= -1,
+	.num_resources	= ARRAY_SIZE(w90x900_emc_resource),
+	.resource	= w90x900_emc_resource,
+};
+
 static struct map_desc w90p910_iodesc[] __initdata = {
 };
 
@@ -242,6 +269,7 @@ static struct platform_device *w90p910evb_dev[] __initdata = {
 	&w90x900_device_rtc,
 	&w90x900_device_kpi,
 	&w90x900_device_usbgadget,
+	&w90p910_device_emc,
 };
 
 static void __init w90p910evb_map_io(void)
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add mac resource support for w90p910
  2009-07-16 12:49 [PATCH] Add mac resource support for w90p910 Wan ZongShun
@ 2009-07-16 13:09 ` Trilok Soni
  2009-07-17  2:01   ` Wan ZongShun
  0 siblings, 1 reply; 4+ messages in thread
From: Trilok Soni @ 2009-07-16 13:09 UTC (permalink / raw)
  To: Wan ZongShun
  Cc: David S. Miller, linux-netdev, linux-arm-kernel, Russell King,
	Eric.miao

Hi Wan,

On Thu, Jul 16, 2009 at 6:19 PM, Wan ZongShun<mcuos.com@gmail.com> wrote:
> +
> +struct platform_device w90p910_device_emc = {

static?

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add mac resource support for w90p910
  2009-07-16 13:09 ` Trilok Soni
@ 2009-07-17  2:01   ` Wan ZongShun
  2009-07-17  5:57     ` Trilok Soni
  0 siblings, 1 reply; 4+ messages in thread
From: Wan ZongShun @ 2009-07-17  2:01 UTC (permalink / raw)
  To: Trilok Soni
  Cc: David S. Miller, linux-netdev, linux-arm-kernel, Russell King,
	Eric.miao

Dear Trilok,

Thanks for your reviewing, I fixed up and resubmitted this patch.

patch text:

Add mac resource support for w90p910 mac driver

Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
---
 arch/arm/mach-w90x900/mach-w90p910evb.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-w90x900/mach-w90p910evb.c b/arch/arm/mach-w90x900/mach-w90p910evb.c
index 7a62bd3..3becabb 100644
--- a/arch/arm/mach-w90x900/mach-w90p910evb.c
+++ b/arch/arm/mach-w90x900/mach-w90p910evb.c
@@ -228,6 +228,33 @@ struct platform_device w90x900_device_usbgadget = {
 };
 EXPORT_SYMBOL(w90x900_device_usbgadget);
 
+/* USB mac device */
+
+static struct resource w90x900_emc_resource[] = {
+	[0] = {
+		.start = W90X900_PA_EMC,
+		.end   = W90X900_PA_EMC + W90X900_SZ_EMC - 1,
+		.flags = IORESOURCE_MEM,
+	},
+	[1] = {
+		.start = IRQ_EMCTX,
+		.end   = IRQ_EMCTX,
+		.flags = IORESOURCE_IRQ,
+	},
+	[2] = {
+		.start = IRQ_EMCRX,
+		.end   = IRQ_EMCRX,
+		.flags = IORESOURCE_IRQ,
+	}
+};
+
+static struct platform_device w90p910_device_emc = {
+	.name		= "w90p910-emc",
+	.id		= -1,
+	.num_resources	= ARRAY_SIZE(w90x900_emc_resource),
+	.resource	= w90x900_emc_resource,
+};
+
 static struct map_desc w90p910_iodesc[] __initdata = {
 };
 
@@ -242,6 +269,7 @@ static struct platform_device *w90p910evb_dev[] __initdata = {
 	&w90x900_device_rtc,
 	&w90x900_device_kpi,
 	&w90x900_device_usbgadget,
+	&w90p910_device_emc,
 };
 
 static void __init w90p910evb_map_io(void)
-- 
1.5.6.3


> Hi Wan,
> 
> On Thu, Jul 16, 2009 at 6:19 PM, Wan ZongShun<mcuos.com@gmail.com> wrote:
>> +
>> +struct platform_device w90p910_device_emc = {
> 
> static?
> 


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add mac resource support for w90p910
  2009-07-17  2:01   ` Wan ZongShun
@ 2009-07-17  5:57     ` Trilok Soni
  0 siblings, 0 replies; 4+ messages in thread
From: Trilok Soni @ 2009-07-17  5:57 UTC (permalink / raw)
  To: Wan ZongShun
  Cc: David S. Miller, linux-netdev, linux-arm-kernel, Russell King,
	Eric.miao

Hi Wan,

On Fri, Jul 17, 2009 at 7:31 AM, Wan ZongShun<mcuos.com@gmail.com> wrote:
> Dear Trilok,
>
> Thanks for your reviewing, I fixed up and resubmitted this patch.
>
> patch text:
>
> Add mac resource support for w90p910 mac driver
>
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> ---
>  arch/arm/mach-w90x900/mach-w90p910evb.c |   28 ++++++++++++++++++++++++++++
>  1 files changed, 28 insertions(+), 0 deletions(-)

Looks good:

Reviewed-by: Trilok Soni <soni.trilok@gmail.com>

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-07-17  5:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-16 12:49 [PATCH] Add mac resource support for w90p910 Wan ZongShun
2009-07-16 13:09 ` Trilok Soni
2009-07-17  2:01   ` Wan ZongShun
2009-07-17  5:57     ` Trilok Soni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).