From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C6DB329C60; Fri, 10 Jul 2026 13:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783689197; cv=none; b=NM6HGh4PjtTM68fqFwDpYehn5Wo/PeNdl7ezaRAZZj02ICkTRVkexSlJytECZUVzvIby2pgc+ooOLirc3aiRuxPnfzRPLevQYRJ4eHuzrhJHCN7TAxCQS7pm8Bn3pdFc/VHy5ebQEaQURvAUCjXbHcY764DbUVcUyU5SoO1vKK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783689197; c=relaxed/simple; bh=d2QyDrs945TnluIMf34hy7lClFButS9NlGOeRk9czVY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LIAsPG21IS/qVsOexk9jO2yWLi5VWgm38FVA7lrWxRomllsv1a0guNBb/K07TwWBKXHyYCcbng4/ubkkFzKvoiq+hsCKL+ob6Vc1EboumgQwM74/vGhhjdukXfvSByZ0b+MxTMzzeIkU54s66TL19IAowk79Jhqw1QIVhBgeQPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=fl2dIF6A; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="fl2dIF6A" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=nSS3kAob3BJ4oEKJED+ufHWz0ooPsoMZ7Zqd8yLDlwE=; b=fl2dIF6A4q4crS4yv7vJpMQXUl Nv4riM/q1KMHDt/YhOYCqebqs0yTbToWZobkJigp3xOhk4UIrP3wlTKwm346zXW3vIe1ijL0S8f7O nMxrKv+ZXHfPYVqEEtDzZrc1Mwbzm4sVDbi65ndiBz1XrkeqRD9AgPFT3Xsz3MpLaVAU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wiB2J-00BdyZ-4j; Fri, 10 Jul 2026 15:12:59 +0200 Date: Fri, 10 Jul 2026 15:12:59 +0200 From: Andrew Lunn To: xiaoning.wang@oss.nxp.com Cc: Frank.Sae@motor-comm.com, leitao@debian.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, xiaoning.wang@nxp.com Subject: Re: [PATCH net V2] net: phy: motorcomm: read EEE abilities in yt8521_get_features() Message-ID: <5d55cc0f-4b9f-42df-880a-290faf201cc8@lunn.ch> References: <20260710080018.1070789-1-xiaoning.wang@oss.nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710080018.1070789-1-xiaoning.wang@oss.nxp.com> > @@ -2490,7 +2490,8 @@ static int yt8521_get_features(struct phy_device *phydev) > /* add fiber's features to phydev->supported */ > yt8521_prepare_fiber_features(phydev, phydev->supported); > } > - return ret; > + > + return ret ? ret : genphy_c45_read_eee_abilities(phydev); Using a ? like this is very uncommon. Please change it to the usual if (ret < 0) return ret; return genphy_c45_read_eee_abilities(phydev); It might also be better to put the test after yt8521_get_features_paged() call, since that is the only place missing the test. Andrew --- pw-bot: cr