From: David Ahern <dsahern@gmail.com>
To: vyasevic@redhat.com, Vladislav Yasevich <vyasevich@gmail.com>,
netdev@vger.kernel.org
Cc: roopa@cumulusnetworks.com, jiri@resnulli.us, vfalico@gmail.com,
andy@greyhouse.net
Subject: Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages
Date: Fri, 26 May 2017 14:04:00 -0600 [thread overview]
Message-ID: <5d8f7bc5-bf2d-19f3-a27a-5a56f1273a6f@gmail.com> (raw)
In-Reply-To: <9e56d973-450e-7dfe-5a33-23922d449cd5@redhat.com>
On 5/26/17 2:01 PM, Vlad Yasevich wrote:
>> Also, generically the IFLA_EVENT attribute should be considered
>> independent of NETDEV_ events.
>>
>> For example, userspace should be notified if the speed / duplex for a
>> device changes, so we could have another one of these -- e.g.,
>> IFLA_EVENT_SPEED -- that does not correlate to NETDEV_SPEED since
>> nothing internal to the network stack cares about speed changes, or
>> perhaps more generically it is IFLA_EVENT_LINK_SETTING.
>>
>
> Ok. We could do a translation between netdev event and IFLA_EVENT attribute value
> earlier (say in rtnetlink_event) and pass that along. This would allow calls
> from other places, assuming proper IFLA_EVENT attribute value and translation
> is defined.
>
> Would that address your concerns?
yes. that code re-factoring can be done when it is needed.
next prev parent reply other threads:[~2017-05-26 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 15:31 [PATCH v5 net-next 0/2] rtnetlink: Updates to rtnetlink_event() Vladislav Yasevich
2017-05-25 15:31 ` [PATCH V5 1/2] rtnl: Add support for netdev event to link messages Vladislav Yasevich
2017-05-26 19:40 ` David Ahern
2017-05-26 20:01 ` Vlad Yasevich
2017-05-26 20:04 ` David Ahern [this message]
2017-05-25 15:31 ` [PATCH V5 2/2] bonding: Prevent duplicate userspace notification Vladislav Yasevich
2017-05-26 19:46 ` David Ahern
2017-05-25 15:31 ` [PATCH V5 iproute] ip: Add support for netdev events to monitor Vladislav Yasevich
2017-05-26 18:30 ` [PATCH v5 net-next 0/2] rtnetlink: Updates to rtnetlink_event() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d8f7bc5-bf2d-19f3-a27a-5a56f1273a6f@gmail.com \
--to=dsahern@gmail.com \
--cc=andy@greyhouse.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=vfalico@gmail.com \
--cc=vyasevic@redhat.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).