From: Eric Dumazet <eric.dumazet@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] net: Get rid of consume_skb when tracing is off
Date: Fri, 21 Aug 2020 16:40:49 -0700 [thread overview]
Message-ID: <5d9b715e-d213-8e82-1a68-aee24c3b589d@gmail.com> (raw)
In-Reply-To: <20200821222329.GA2633@gondor.apana.org.au>
On 8/21/20 3:23 PM, Herbert Xu wrote:
> The function consume_skb is only meaningful when tracing is enabled.
> This patch makes it conditional on CONFIG_TRACEPOINTS.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
I am not completely familiar with CONFIG_TRACEPOINTS
Is "perf probe" support requiring it ?
We want the following to be supported.
perf probe consume_skb
next prev parent reply other threads:[~2020-08-21 23:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 22:23 [PATCH] net: Get rid of consume_skb when tracing is off Herbert Xu
2020-08-21 23:40 ` Eric Dumazet [this message]
2020-08-22 1:08 ` Herbert Xu
2020-08-22 17:54 ` Neil Horman
2020-08-22 19:49 ` David Miller
2020-08-24 12:17 ` Neil Horman
2020-08-22 22:47 ` Herbert Xu
2020-08-24 23:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d9b715e-d213-8e82-1a68-aee24c3b589d@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).