* [[PATCH net]] ptp: ocp: remove symlink for second GNSS
@ 2022-10-10 1:29 Vadim Fedorenko
2022-10-10 3:45 ` Jonathan Lemon
2022-10-10 7:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2022-10-10 1:29 UTC (permalink / raw)
To: Jonathan Lemon; +Cc: netdev, Vadim Fedorenko, Vadim Fedorenko
Destroy code doesn't remove symlink for ttyGNSS2 device introduced
earlier. Add cleanup code.
Fixes: 71d7e0850476 ("ptp: ocp: Add second GNSS device")
Signed-off-by: Vadim Fedorenko <vadfed@fb.com>
---
drivers/ptp/ptp_ocp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index d36c3f597f77..a48d9b7d2921 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -3657,6 +3657,7 @@ ptp_ocp_detach_sysfs(struct ptp_ocp *bp)
struct device *dev = &bp->dev;
sysfs_remove_link(&dev->kobj, "ttyGNSS");
+ sysfs_remove_link(&dev->kobj, "ttyGNSS2");
sysfs_remove_link(&dev->kobj, "ttyMAC");
sysfs_remove_link(&dev->kobj, "ptp");
sysfs_remove_link(&dev->kobj, "pps");
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [[PATCH net]] ptp: ocp: remove symlink for second GNSS
2022-10-10 1:29 [[PATCH net]] ptp: ocp: remove symlink for second GNSS Vadim Fedorenko
@ 2022-10-10 3:45 ` Jonathan Lemon
2022-10-10 7:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Lemon @ 2022-10-10 3:45 UTC (permalink / raw)
To: Vadim Fedorenko, Jonathan Lemon; +Cc: netdev, Vadim Fedorenko
On 10/9/22 6:29 PM, Vadim Fedorenko wrote:
> Destroy code doesn't remove symlink for ttyGNSS2 device introduced
> earlier. Add cleanup code.
>
> Fixes: 71d7e0850476 ("ptp: ocp: Add second GNSS device")
> Signed-off-by: Vadim Fedorenko <vadfed@fb.com>
Thanks, Vadim!
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
> drivers/ptp/ptp_ocp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index d36c3f597f77..a48d9b7d2921 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3657,6 +3657,7 @@ ptp_ocp_detach_sysfs(struct ptp_ocp *bp)
> struct device *dev = &bp->dev;
>
> sysfs_remove_link(&dev->kobj, "ttyGNSS");
> + sysfs_remove_link(&dev->kobj, "ttyGNSS2");
> sysfs_remove_link(&dev->kobj, "ttyMAC");
> sysfs_remove_link(&dev->kobj, "ptp");
> sysfs_remove_link(&dev->kobj, "pps");
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [[PATCH net]] ptp: ocp: remove symlink for second GNSS
2022-10-10 1:29 [[PATCH net]] ptp: ocp: remove symlink for second GNSS Vadim Fedorenko
2022-10-10 3:45 ` Jonathan Lemon
@ 2022-10-10 7:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-10 7:40 UTC (permalink / raw)
To: Vadim Fedorenko; +Cc: jonathan.lemon, netdev, vadfed
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 10 Oct 2022 04:29:34 +0300 you wrote:
> Destroy code doesn't remove symlink for ttyGNSS2 device introduced
> earlier. Add cleanup code.
>
> Fixes: 71d7e0850476 ("ptp: ocp: Add second GNSS device")
> Signed-off-by: Vadim Fedorenko <vadfed@fb.com>
> ---
> drivers/ptp/ptp_ocp.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [[PATCH,net] ] ptp: ocp: remove symlink for second GNSS
https://git.kernel.org/netdev/net/c/84cdf5bcbdce
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-10 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-10 1:29 [[PATCH net]] ptp: ocp: remove symlink for second GNSS Vadim Fedorenko
2022-10-10 3:45 ` Jonathan Lemon
2022-10-10 7:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).