From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A60C43217 for ; Tue, 8 Nov 2022 10:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233888AbiKHKZD (ORCPT ); Tue, 8 Nov 2022 05:25:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232641AbiKHKZA (ORCPT ); Tue, 8 Nov 2022 05:25:00 -0500 Received: from nbd.name (nbd.name [46.4.11.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A8FB1B1FC; Tue, 8 Nov 2022 02:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:From :References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2JjPFhp59qtLP/Cp/TS7I43kY8BphcdVe01unYamrKs=; b=mLx8VPk292EGLbdbeCGKQ7e10l 096nIOzgzfz4aHdsXB1JX7ZXZVM2SffVBKZFc+5WG/RuWFqyvFwHixx1uX9zynu09gKtLt/ASZgpw Oq++kiJkBCBuVqAOYSCmRQSx3luRIl8KM4izR5Iqrr5v4BNCXWe27SJweYefIkzkUoJM=; Received: from p200300daa72ee1006d973cebf3767a25.dip0.t-ipconnect.de ([2003:da:a72e:e100:6d97:3ceb:f376:7a25] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1osLml-000UT6-JD; Tue, 08 Nov 2022 11:24:51 +0100 Message-ID: <5dbfa404-ec02-ac41-8c9b-55f8dfb7800a@nbd.name> Date: Tue, 8 Nov 2022 11:24:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Content-Language: en-US To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org References: <20221107185452.90711-1-nbd@nbd.name> <20221107185452.90711-8-nbd@nbd.name> <20221107215745.ascdvnxqrbw4meuv@skbuf> <3b275dda-39ac-282d-8a46-d3a95fdfc766@nbd.name> <20221108090039.imamht5iyh2bbbnl@skbuf> <0948d841-b0eb-8281-455a-92f44586e0c0@nbd.name> <20221108094018.6cspe3mkh3hakxpd@skbuf> <20221108100851.tl5aqhmbc5altdwv@skbuf> From: Felix Fietkau Subject: Re: [PATCH 08/14] net: vlan: remove invalid VLAN protocol warning In-Reply-To: <20221108100851.tl5aqhmbc5altdwv@skbuf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 08.11.22 11:08, Vladimir Oltean wrote: > On Tue, Nov 08, 2022 at 10:46:54AM +0100, Felix Fietkau wrote: >> I think it depends on the hardware. If you can rely on the hardware always >> reporting the port out-of-band, a generic "oob" tagger would be fine. >> In my case, it depends on whether a second non-DSA ethernet MAC is active on >> the same device, so I do need to continue using the "mtk" tag driver. > > It's not only about the time dimension (always OOB, vs sometimes OOB), > but also about what is conveyed through the OOB tag. I can see 2 vendors > agreeing today on a common "oob" tagger only to diverge in the future > when they'll need to convey more information than just port id. What do > you do with the tagging protocol string names then. Gotta make them > unique from the get go, can't export "oob" to user space IMO. > >> The flow dissector part is already solved: I simply used the existing >> .flow_dissect() tag op. > > Yes, well this seems like a generic enough case (DSA offload tag present > => don't shift network header because it's where it should be) to treat > it in the generic flow dissector and not have to invoke any tagger-specific > fixup method. In that case I think we shouldn't use METADATA_HW_PORT_MUX, since it is already used for other purposes. I will add a new metadata type METADATA_DSA instead. - Felix