From: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
To: Stefano Brivio <sbrivio@redhat.com>,
Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
kernel@openvz.org
Subject: Re: [PATCH nf 1/2] nft_set_pipapo: Fix bucket load in AVX2 lookup routine for six 8-bit groups
Date: Mon, 29 Nov 2021 07:35:23 +0300 [thread overview]
Message-ID: <5dc1bd99-38ea-a136-5b98-05fc366ac310@virtuozzo.com> (raw)
In-Reply-To: <5577a613f815575804cb19754f064071b852bbab.1637976889.git.sbrivio@redhat.com>
> The sixth byte of packet data has to be looked up in the sixth group,
> not in the seventh one, even if we load the bucket data into ymm6
> (and not ymm5, for convenience of tracking stalls).
>
> Without this fix, matching on a MAC address as first field of a set,
> if 8-bit groups are selected (due to a small set size) would fail,
> that is, the given MAC address would never match.
>
> Reported-by: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
> Cc: <stable@vger.kernel.org> # 5.6.x
> Fixes: 7400b063969b ("nft_set_pipapo: Introduce AVX2-based lookup implementation")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tried it. The issue is indeed fixed.
Tested-By: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
next prev parent reply other threads:[~2021-11-29 4:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 10:33 [PATCH nf 0/2] nft_set_pipapo: Fix AVX2 MAC address match, add test Stefano Brivio
2021-11-27 10:33 ` [PATCH nf 1/2] nft_set_pipapo: Fix bucket load in AVX2 lookup routine for six 8-bit groups Stefano Brivio
2021-11-29 4:35 ` Nikita Yushchenko [this message]
2021-11-27 10:33 ` [PATCH nf 2/2] selftests: netfilter: Add correctness test for mac,net set type Stefano Brivio
2021-11-27 11:22 ` Greg KH
2021-11-27 12:42 ` Stefano Brivio
2021-12-08 0:25 ` [PATCH nf 0/2] nft_set_pipapo: Fix AVX2 MAC address match, add test Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dc1bd99-38ea-a136-5b98-05fc366ac310@virtuozzo.com \
--to=nikita.yushchenko@virtuozzo.com \
--cc=fw@strlen.de \
--cc=kernel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).