From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1814B204C28 for ; Tue, 18 Mar 2025 08:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287988; cv=none; b=Uu/FNElLDnNNycP/Umaar12zI/5ggXPyhs6jxFetjyLY0W88t+d0BmXhh3m46l6SjcSX3RmTqBUG5e6sn6Lk+rJVg7TDYOlF1XKPTipCOhHj92Rl2RrS0s85qKjuLY+y4GBL0yIBLJ9F4HAHFyeJDe4tbbJ+ue9LwsXvt3kzQt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742287988; c=relaxed/simple; bh=nBqnAgBHS2l95Pjj/TfnmDtdp5MvYiOaOhdplM2mhmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KF+D3TpixAp3oSj6umomKHF6E/Llv6/kzOZ3CAjV0hci7SckqkpvFPXqm7wn12kPJQ6ylsav9PRMMgk26ZvT6Zi8dkiTk7bvMP84e+E5klk+8HbkQNx0mrYbVqfVNpNDq4XNtXmf85bTpG3RNX07Un2m6+G65aMcYI2oHB6O+X0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cheHwdgJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cheHwdgJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742287985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tObLTe69QFxvzolejx3T+2gunDSqNceNELAPgsdaeHE=; b=cheHwdgJ54e2fxde1jpn1MRCNp96Depd5I7bBOWwpNMa0G7a+wpdQpD8zSVwjccrGTUurG OGBVS/isoQ2NWGg4QCxUnGnUkYnGfOAl2GMrgBgVQsaW4fDZxqpRv7/Yf5BaYrGl31S0Z/ X6VyPhtAg7kWIhY8mF6yRippRC1UG3A= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-8mskpexAMRmC6SHyzSsoIA-1; Tue, 18 Mar 2025 04:53:03 -0400 X-MC-Unique: 8mskpexAMRmC6SHyzSsoIA-1 X-Mimecast-MFC-AGG-ID: 8mskpexAMRmC6SHyzSsoIA_1742287982 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf3168b87so16356445e9.2 for ; Tue, 18 Mar 2025 01:53:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742287982; x=1742892782; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tObLTe69QFxvzolejx3T+2gunDSqNceNELAPgsdaeHE=; b=VgwFu6VWSRE4j7ZoHnWCX6ceMnqGa8TgVJLosSfORbezDIhHRVOsVmtFxP3LsgqiqJ QcKnDDVuk35RWVk5hJbnAW0bxqlhlrmTv565tSi89F0VQTHuVr9ojH5TeCOGi2layzfi HeL6mXfDl4x+ZoNdsgsHD+lHUyqsO7DGY6Gqic+r/Eg3w5q0Nh63+bcEHdL2bVaJbWNI djF4n4XzI+OAyMKwjK8ag2cNGxToGNVKgP0nTYQJyAC+qdtGQeerQ5fYKZZoAfBUhnjG 1idg/TAviKrFJ8VzaySZqz6DtYKEFYjJwvtjOb1gdjgBtOmIHVhioaVbcOmyq9YvW+4n rJtA== X-Forwarded-Encrypted: i=1; AJvYcCVJ6NjNwF1CCKvUBlNdgNBjRLfBGLoczvnFYnc+3x/1SiPykku01UUCa8kncJs3vKVWr/xsktU=@vger.kernel.org X-Gm-Message-State: AOJu0YykOa4yiDthNDX2ptG3wbBm0xcnhvlc1rjnG2SlVn03+YqjYPqL CKw/kG3ay9HFc8gMiH/YWXtOIA7i/tLRiVoYlifbYsSrllZYMpGiGZ0MEPAs8c8rayjwZCNyvCx R0MLFZqY5ASawfRt1ogXFmuFIOozWbJd+mrDAHQMakLV9X/OxpEBA8Q== X-Gm-Gg: ASbGncuK7DAN4hrpCf3Z9MK9Vno83UVxmpk/JnhbOe2i4pA4OHwaB0zHzpfxf0e3zGj 35xINJQE1T7Hz1KY47RUruX+GyzBj3vGWeYALwRLYgDZQuUjvx7jqZzGpYXjjjxBMOnpXPnlON+ X/wPKTlimSMN0m8OEXP2vV7xI6+IHTeVis5wc2qXUisOE/v3VRqMp2QBJYl0PenGKH9bdMMJNda Po2AxDS+lFhySA/iVKrxO2KW6l63TjXzlck3cvt/1lrEIycwd+y+OXNT0YrhbQhhWpihUrIbU7B oWvStWYjZSC9GgSBZU6cYbhA4zpgAVZpd3vWQy5hNR0zQw== X-Received: by 2002:a05:600c:1910:b0:43b:cc3c:60bc with SMTP id 5b1f17b1804b1-43d3b98e784mr10214065e9.15.1742287982444; Tue, 18 Mar 2025 01:53:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLxkKyNtE11z59H06IZJtl8h4j7bAu1UH3i6QG52S1C4EP04HZjwsPQi3k1NceSqvEw/VDKQ== X-Received: by 2002:a05:600c:1910:b0:43b:cc3c:60bc with SMTP id 5b1f17b1804b1-43d3b98e784mr10213835e9.15.1742287982025; Tue, 18 Mar 2025 01:53:02 -0700 (PDT) Received: from [192.168.88.253] (146-241-10-172.dyn.eolo.it. [146.241.10.172]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c8975d65sm17738818f8f.56.2025.03.18.01.52.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 01:53:01 -0700 (PDT) Message-ID: <5de5943b-5527-49f6-a454-b3c7358cff56@redhat.com> Date: Tue, 18 Mar 2025 09:52:59 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 4/9] net: devmem: Implement TX path To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kselftest@vger.kernel.org, Kuniyuki Iwashima Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , Jonathan Corbet , Andrew Lunn , Jeroen de Borst , Harshitha Ramamurthy , Kuniyuki Iwashima , Willem de Bruijn , David Ahern , Neal Cardwell , Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Shuah Khan , sdf@fomichev.me, asml.silence@gmail.com, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja , Kaiyuan Zhang References: <20250308214045.1160445-1-almasrymina@google.com> <20250308214045.1160445-5-almasrymina@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250308214045.1160445-5-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Adding Kuniyuki. On 3/8/25 10:40 PM, Mina Almasry wrote: > @@ -931,10 +932,67 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info) > return err; > } > > -/* stub */ > int netdev_nl_bind_tx_doit(struct sk_buff *skb, struct genl_info *info) > { > - return 0; > + struct net_devmem_dmabuf_binding *binding; > + struct list_head *sock_binding_list; > + struct net_device *netdev; > + u32 ifindex, dmabuf_fd; > + struct sk_buff *rsp; > + int err = 0; > + void *hdr; > + > + if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_DEV_IFINDEX) || > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_DMABUF_FD)) > + return -EINVAL; > + > + ifindex = nla_get_u32(info->attrs[NETDEV_A_DEV_IFINDEX]); > + dmabuf_fd = nla_get_u32(info->attrs[NETDEV_A_DMABUF_FD]); > + > + sock_binding_list = genl_sk_priv_get(&netdev_nl_family, > + NETLINK_CB(skb).sk); > + if (IS_ERR(sock_binding_list)) > + return PTR_ERR(sock_binding_list); > + > + rsp = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL); > + if (!rsp) > + return -ENOMEM; > + > + hdr = genlmsg_iput(rsp, info); > + if (!hdr) { > + err = -EMSGSIZE; > + goto err_genlmsg_free; > + } > + > + rtnl_lock(); The above could possibly be a rtnl_net_lock(), right? (not strictily related to this series) The same for the existing rtnl_lock() call in netdev-genl.c, right? /P