netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Burton <paulburton@kernel.org>
To: Alexander Lobakin <alobakin@dlink.ru>
Cc: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	James Hogan <jhogan@kernel.org>,
	Hassan Naveed <hnaveed@wavecomp.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
	Alexander Lobakin <alobakin@dlink.ru>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, bpf@vger.kernel.org,
	stable@vger.kernel.org
Cc: linux-mips@vger.kernel.org
Subject: Re: [PATCH mips-fixes] MIPS: BPF: eBPF JIT: check for MIPS ISA compliance  in Kconfig
Date: Fri, 06 Dec 2019 11:18:47 -0800	[thread overview]
Message-ID: <5deaa997.1c69fb81.4d5ed.a377@mx.google.com> (raw)
In-Reply-To: <20191206080741.12306-1-alobakin@dlink.ru>

Hello,

Alexander Lobakin wrote:
> It is completely wrong to check for compile-time MIPS ISA revision in
> the body of bpf_int_jit_compile() as it may lead to get MIPS JIT fully
> omitted by the CC while the rest system will think that the JIT is
> actually present and works [1].
> We can check if the selected CPU really supports MIPS eBPF JIT at
> configure time and avoid such situations when kernel can be built
> without both JIT and interpreter, but with CONFIG_BPF_SYSCALL=y.
> 
> [1] https://lore.kernel.org/linux-mips/09d713a59665d745e21d021deeaebe0a@dlink.ru/

Applied to mips-fixes.

> commit 3721376d7d02
> https://git.kernel.org/mips/c/3721376d7d02
> 
> Fixes: 716850ab104d ("MIPS: eBPF: Initial eBPF support for MIPS32 architecture.")
> Signed-off-by: Alexander Lobakin <alobakin@dlink.ru>
> Signed-off-by: Paul Burton <paulburton@kernel.org>

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paulburton@kernel.org to report it. ]

      reply	other threads:[~2019-12-06 19:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06  8:07 [PATCH mips-fixes] MIPS: BPF: eBPF JIT: check for MIPS ISA compliance in Kconfig Alexander Lobakin
2019-12-06 19:18 ` Paul Burton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5deaa997.1c69fb81.4d5ed.a377@mx.google.com \
    --to=paulburton@kernel.org \
    --cc=alobakin@dlink.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).