From: Cole Robinson <crobinso@redhat.com>
To: josef@toxicpanda.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
labbott@redhat.com, kernel-team@fb.com
Subject: Re: [PATCH 0/3] fix reuseaddr regression
Date: Mon, 18 Sep 2017 13:44:32 -0400 [thread overview]
Message-ID: <5df48cbb-2726-3e99-84e7-eb6c6fc0dbb2@redhat.com> (raw)
In-Reply-To: <1505752137-15522-1-git-send-email-jbacik@fb.com>
On 09/18/2017 12:28 PM, josef@toxicpanda.com wrote:
> I introduced a regression when reworking the fastreuse port stuff that allows
> bind conflicts to occur once a reuseaddr socket successfully opens on an
> existing tb. The root cause is I reversed an if statement which caused us to
> set the tb as if there were no owners on the socket if there were, which
> obviously is not correct.
>
> Dave I have follow up patches that will add a selftest for this case and I ran
> the other reuseport related tests as well. These need to go in pretty quickly
> as it breaks kvm, I've marked them for stable. Sorry for the regression,
>
To clarify, it doesn't really break KVM specifically, but it breaks a
port collision detection idiom that libvirt depends on to successfully
launch qemu/xen/... VMs in certain cases.
Thanks,
Cole
next prev parent reply other threads:[~2017-09-18 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 16:28 [PATCH 0/3] fix reuseaddr regression josef
2017-09-18 16:28 ` [PATCH 1/3] net: set tb->fast_sk_family josef
2017-09-18 16:28 ` [PATCH 2/3] net: use inet6_rcv_saddr to compare sockets josef
2017-09-18 16:28 ` [PATCH 3/3] inet: fix improper empty comparison josef
2017-09-18 17:44 ` Cole Robinson [this message]
2017-09-19 20:50 ` [PATCH 0/3] fix reuseaddr regression David Miller
2017-09-23 0:28 ` Josef Bacik
-- strict thread matches above, loose matches on Subject: below --
2017-09-23 0:20 Josef Bacik
2017-09-23 3:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5df48cbb-2726-3e99-84e7-eb6c6fc0dbb2@redhat.com \
--to=crobinso@redhat.com \
--cc=davem@davemloft.net \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).