From: Sathya Perla <sathya.perla@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: RE: [patch] be2net: signedness bug in be_msix_enable()
Date: Thu, 30 Jun 2016 16:52:56 +0530 [thread overview]
Message-ID: <5e01e26fa672cf9686fdbc8d4448ffd2@mail.gmail.com> (raw)
In-Reply-To: <20160629143943.GA22818@mwanda>
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>
> "num_vec" needs to be signed for the error handling to work.
>
> Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
> index 1873c74..1f16e73 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter
*adapter)
>
> static int be_msix_enable(struct be_adapter *adapter) {
> - unsigned int i, num_vec, max_roce_eqs;
> + unsigned int i, max_roce_eqs;
> struct device *dev = &adapter->pdev->dev;
> + int num_vec;
>
Oops...thanks for catching this! This must go into net-next.
Acked-by: Sathya Perla <sathya.perla@broadcom.com>
next prev parent reply other threads:[~2016-06-30 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:39 [patch] be2net: signedness bug in be_msix_enable() Dan Carpenter
2016-06-30 11:22 ` Sathya Perla [this message]
2016-06-30 12:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e01e26fa672cf9686fdbc8d4448ffd2@mail.gmail.com \
--to=sathya.perla@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).