From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97EA4C43381 for ; Mon, 25 Mar 2019 16:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 518B920828 for ; Mon, 25 Mar 2019 16:31:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WASHSjUV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728957AbfCYQbw (ORCPT ); Mon, 25 Mar 2019 12:31:52 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33930 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbfCYQbw (ORCPT ); Mon, 25 Mar 2019 12:31:52 -0400 Received: by mail-pl1-f196.google.com with SMTP id y6so195613plt.1 for ; Mon, 25 Mar 2019 09:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=67OwIMrQh4HBeMCC0XA3B3nCCm1H4QINxdzXCjrKgu8=; b=WASHSjUVIHM1znMcYh6EN9PZvUS+ihW58nipR+OIvmKp6pG29Stm2v7ONWLdRbRFvA pYwh64pdRoZ5DIwUxj2pbi26rYErSTBFFtaGrFAkccxxBDuNDKnWnEPwxAay+1CMMxqg FM+mMuGYvR5ZQ/q+o2aS2YAkpR1dDqYyV5OZHqufoesXGdUIhaR45z2f0sSOKxC/souq CEA/TdKR0V9HBxw2+CCYR2Aq/OGmHyxEQzuiHKuy76aSJmVqyAQOO7+GYDape1W3k327 f0Eb26gXVEci9rg5oQUuXeFlqMI9jT5ElBsARpSD8Y8H8og1osF0jdTT89lvP+1c7+30 TXpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=67OwIMrQh4HBeMCC0XA3B3nCCm1H4QINxdzXCjrKgu8=; b=F6nEVRn43O/wSZ0BCGvcxx1OH/Gb2SZEGnICoVBATVxEwtbFLKXY5mc4WG+B0q1Vmi Z/hIL3uCeX3nAGtXAnWWxhNMdWqJHbFaC7OdunqyFBCacVi9OLt9cNyU8n910ruD0Ayz 4dv7HfiT4VI7JAUDFnGVADOphkhXeoCU/5DJFCuCWpIGSW9yW2GZK3QcCtsmOIIKDWpM aWOBNYhaH5b+6WemHnU04YD8sSr2WnX1MJOE/NUzk8M9ZFQzE9z967Hg5af/qDD+rc56 yXki4CCIolJpw3e55u9vXb1IQfUvmUiVbdbQLR7EfEdukbZxKWrQ1RgR1UTpBfIKpnLS fVVQ== X-Gm-Message-State: APjAAAUw3vDcZSj8Ra1KhvryzPFxxmtFcRkz9pL1i50RvvuaTq8elmgl npTVtar+jpmMGAzUmaU5m3Q= X-Google-Smtp-Source: APXvYqypEzmjvwaSNsA+gyyCuF9fQOR5AUEzx7r0qQHmlwLZvEe+WiXd+eqeqwkzUllNSNcqnKtkbw== X-Received: by 2002:a17:902:e20e:: with SMTP id ce14mr12316743plb.193.1553531511341; Mon, 25 Mar 2019 09:31:51 -0700 (PDT) Received: from [10.67.48.231] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id s4sm18330617pgp.89.2019.03.25.09.31.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 09:31:50 -0700 (PDT) Subject: Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA driver To: Vladimir Oltean , davem@davemloft.net, netdev@vger.kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, linus.walleij@linaro.org References: <20190324032346.32394-1-olteanv@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <5e299151-3914-30c0-69e7-d623bd7207c6@gmail.com> Date: Mon, 25 Mar 2019 09:31:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190324032346.32394-1-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/23/19 8:23 PM, Vladimir Oltean wrote: > This patchset adds a DSA driver for the SPI-managed NXP SJA1105 driver. > Due to the hardware's unfriendliness, most of its state needs to be > shadowed in kernel memory by the driver. To support this and keep a > decent amount of cleanliness in the code, a new generic API for > converting between CPU-accessible ("unpacked") structures and > hardware-accessible ("packed") structures is proposed and used. > > Then several small modifications are done to the DSA core, like changing > the order of two calls during initialization, or permitting driver > access to the dp->vlan_filtering property. > > These small modifications are done for the greater goal of adding > support for 802.1Q pseudo-switch tagging. The limitations of this type > of tagging are discussed in the commit that adds it, and in the code > comments. > > The SJA1105 driver then proceeds to extend this 8021q switch tagging > protocol while adding its own (tag_sja1105). This is done because > SJA1105 needs SPI intervention during transmission of link-local > traffic, which cannot be done from the xmit handler but requires a > deferred worker thread. > > The driver is GPL-2.0 licensed. The source code files which are licensed > as BSD-3-Clause are hardware support files and derivative of the > userspace NXP sja1105-tool program, which is BSD-3-Clause licensed. > > TODO items: > * Add full support for the P/Q/R/S series. The patches were mostly > tested on a first-generation T device. > * Add timestamping support and PTP clock manipulation. > * Figure out what the current state of tc-taprio hw offload is, and > attempt to configure the switch's time-aware scheduler using that. Overall this is a very clean and impressive piece of work, especially given the constraints you have to work with, I will follow-up with comments in individual patches thanks Vladimir! > > Vladimir Oltean (13): > lib: Add support for generic packing operations > net: dsa: Store vlan_filtering as a property of dsa_port > net: dsa: Create a more convenient function for installing port VLANs > net: dsa: Call driver's setup callback after setting up its switchdev > notifier > net: dsa: Optional VLAN-based port separation for switches without > tagging > net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch > net: dsa: sja1105: Add support for FDB and MDB management > net: dsa: sja1105: Add support for VLAN operations > net: dsa: sja1105: Add support for ethtool port counters > net: dsa: sja1105: Add support for traffic through standalone ports > net: dsa: sja1105: Add support for Spanning Tree Protocol > Documentation: networking: dsa: Add details about NXP SJA1105 driver > dt-bindings: net: dsa: Add documentation for NXP SJA1105 driver > > .../devicetree/bindings/net/dsa/sja1105.txt | 123 ++ > Documentation/networking/dsa/sja1105.txt | 83 + > Documentation/packing.txt | 150 ++ > MAINTAINERS | 14 + > drivers/net/dsa/Kconfig | 2 + > drivers/net/dsa/Makefile | 1 + > drivers/net/dsa/sja1105/Kconfig | 17 + > drivers/net/dsa/sja1105/Makefile | 10 + > drivers/net/dsa/sja1105/sja1105.h | 148 ++ > drivers/net/dsa/sja1105/sja1105_clocking.c | 677 ++++++ > .../net/dsa/sja1105/sja1105_dynamic_config.c | 607 ++++++ > .../net/dsa/sja1105/sja1105_dynamic_config.h | 40 + > drivers/net/dsa/sja1105/sja1105_ethtool.c | 420 ++++ > drivers/net/dsa/sja1105/sja1105_main.c | 1580 ++++++++++++++ > drivers/net/dsa/sja1105/sja1105_spi.c | 667 ++++++ > .../net/dsa/sja1105/sja1105_static_config.c | 1810 +++++++++++++++++ > .../net/dsa/sja1105/sja1105_static_config.h | 500 +++++ > include/linux/dsa/sja1105.h | 52 + > include/linux/packing.h | 49 + > include/net/dsa.h | 6 + > lib/Makefile | 2 +- > lib/packing.c | 211 ++ > net/dsa/Kconfig | 12 + > net/dsa/Makefile | 2 + > net/dsa/dsa.c | 6 + > net/dsa/dsa2.c | 8 +- > net/dsa/dsa_priv.h | 15 + > net/dsa/port.c | 36 +- > net/dsa/slave.c | 16 +- > net/dsa/tag_8021q.c | 185 ++ > net/dsa/tag_sja1105.c | 142 ++ > 31 files changed, 7568 insertions(+), 23 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/dsa/sja1105.txt > create mode 100644 Documentation/networking/dsa/sja1105.txt > create mode 100644 Documentation/packing.txt > create mode 100644 drivers/net/dsa/sja1105/Kconfig > create mode 100644 drivers/net/dsa/sja1105/Makefile > create mode 100644 drivers/net/dsa/sja1105/sja1105.h > create mode 100644 drivers/net/dsa/sja1105/sja1105_clocking.c > create mode 100644 drivers/net/dsa/sja1105/sja1105_dynamic_config.c > create mode 100644 drivers/net/dsa/sja1105/sja1105_dynamic_config.h > create mode 100644 drivers/net/dsa/sja1105/sja1105_ethtool.c > create mode 100644 drivers/net/dsa/sja1105/sja1105_main.c > create mode 100644 drivers/net/dsa/sja1105/sja1105_spi.c > create mode 100644 drivers/net/dsa/sja1105/sja1105_static_config.c > create mode 100644 drivers/net/dsa/sja1105/sja1105_static_config.h > create mode 100644 include/linux/dsa/sja1105.h > create mode 100644 include/linux/packing.h > create mode 100644 lib/packing.c > create mode 100644 net/dsa/tag_8021q.c > create mode 100644 net/dsa/tag_sja1105.c > -- Florian