From: Thor Thayer <thor.thayer@linux.intel.com>
To: dwesterg@gmail.com, netdev@vger.kernel.org, dinguyen@kernel.org,
richardcochran@gmail.com, davem@davemloft.net,
vbridger@opensource.altera.com, robh+dt@kernel.org,
"mark.rutland@arm.commark.rutland"@arm.com,
devicetree@vger.kernel.org, hean.loong.ong@intel.com
Cc: Dalon Westergreen <dalon.westergreen@intel.com>
Subject: Re: [PATCH v2 net-next 03/10] net: eth: altera: fix altera_dmaops declaration
Date: Tue, 18 Dec 2018 09:33:48 -0600 [thread overview]
Message-ID: <5e34b170-4365-e4a6-18e8-bb2396ad85a9@linux.intel.com> (raw)
In-Reply-To: <20181213175252.21143-4-dalon.westergreen@linux.intel.com>
On 12/13/18 11:52 AM, dwesterg@gmail.com wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
>
> The declaration of struct altera_dmaops does not have
> identifier names. Add identifier names to confrom with
> required coding styles.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> ---
> drivers/net/ethernet/altera/altera_tse.h | 30 +++++++++++++-----------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h
> index e2feee87180a..d5b97e02e6d6 100644
> --- a/drivers/net/ethernet/altera/altera_tse.h
> +++ b/drivers/net/ethernet/altera/altera_tse.h
> @@ -396,20 +396,22 @@ struct altera_tse_private;
> struct altera_dmaops {
> int altera_dtype;
> int dmamask;
> - void (*reset_dma)(struct altera_tse_private *);
> - void (*enable_txirq)(struct altera_tse_private *);
> - void (*enable_rxirq)(struct altera_tse_private *);
> - void (*disable_txirq)(struct altera_tse_private *);
> - void (*disable_rxirq)(struct altera_tse_private *);
> - void (*clear_txirq)(struct altera_tse_private *);
> - void (*clear_rxirq)(struct altera_tse_private *);
> - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *);
> - u32 (*tx_completions)(struct altera_tse_private *);
> - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *);
> - u32 (*get_rx_status)(struct altera_tse_private *);
> - int (*init_dma)(struct altera_tse_private *);
> - void (*uninit_dma)(struct altera_tse_private *);
> - void (*start_rxdma)(struct altera_tse_private *);
> + void (*reset_dma)(struct altera_tse_private *priv);
> + void (*enable_txirq)(struct altera_tse_private *priv);
> + void (*enable_rxirq)(struct altera_tse_private *priv);
> + void (*disable_txirq)(struct altera_tse_private *priv);
> + void (*disable_rxirq)(struct altera_tse_private *priv);
> + void (*clear_txirq)(struct altera_tse_private *priv);
> + void (*clear_rxirq)(struct altera_tse_private *priv);
> + int (*tx_buffer)(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> + u32 (*tx_completions)(struct altera_tse_private *priv);
> + void (*add_rx_desc)(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> + u32 (*get_rx_status)(struct altera_tse_private *priv);
> + int (*init_dma)(struct altera_tse_private *priv);
> + void (*uninit_dma)(struct altera_tse_private *priv);
> + void (*start_rxdma)(struct altera_tse_private *priv);
> };
>
> /* This structure is private to each device.
>
Acked-by: Thor Thayer <thor.thayer@linux.intel.com>
next prev parent reply other threads:[~2018-12-18 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181213175252.21143-1-dalon.westergreen@linux.intel.com>
[not found] ` <20181213175252.21143-2-dalon.westergreen@linux.intel.com>
2018-12-18 15:32 ` [PATCH v2 net-next 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response Thor Thayer
[not found] ` <20181213175252.21143-3-dalon.westergreen@linux.intel.com>
2018-12-18 15:33 ` [PATCH v2 net-next 02/10] net: eth: altera: set rx and tx ring size before init_dma call Thor Thayer
[not found] ` <20181213175252.21143-4-dalon.westergreen@linux.intel.com>
2018-12-18 15:33 ` Thor Thayer [this message]
[not found] ` <20181213175252.21143-5-dalon.westergreen@linux.intel.com>
2018-12-18 15:34 ` [PATCH v2 net-next 04/10] net: eth: altera: add optional function to start tx dma Thor Thayer
[not found] ` <20181213175252.21143-6-dalon.westergreen@linux.intel.com>
2018-12-18 15:37 ` [PATCH v2 net-next 05/10] net: eth: altera: Move common functions to altera_utils Thor Thayer
[not found] ` <20181213175252.21143-7-dalon.westergreen@linux.intel.com>
2018-12-18 15:45 ` [PATCH v2 net-next 06/10] net: eth: altera: Add missing identifier names to function declarations Thor Thayer
[not found] ` <20181213175252.21143-8-dalon.westergreen@linux.intel.com>
2018-12-18 15:48 ` [PATCH v2 net-next 07/10] net: eth: altera: change tx functions to type netdev_tx_t Thor Thayer
[not found] ` <20181213175252.21143-9-dalon.westergreen@linux.intel.com>
2018-12-19 4:27 ` [PATCH v2 net-next 08/10] net: eth: altera: add support for ptp and timestamping Richard Cochran
2018-12-19 19:27 ` Westergreen, Dalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e34b170-4365-e4a6-18e8-bb2396ad85a9@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc="mark.rutland@arm.commark.rutland"@arm.com \
--cc=dalon.westergreen@intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dwesterg@gmail.com \
--cc=hean.loong.ong@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vbridger@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).