From: Jiangfeng Xiao <xiaojiangfeng@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<davem@davemloft.net>, <robh+dt@kernel.org>,
<yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<mark.rutland@arm.com>, <dingtianhong@huawei.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <leeyou.li@huawei.com>,
<nixiaoming@huawei.com>, <jianping.liu@huawei.com>,
<xiekunxun@huawei.com>
Subject: Re: [PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first
Date: Wed, 10 Jul 2019 13:05:20 +0800 [thread overview]
Message-ID: <5e3eda91-dedc-e687-6a18-b1aec1e9fe63@huawei.com> (raw)
In-Reply-To: <101b8c68-75f5-00a7-9845-e59c0467768c@huawei.com>
On 2019/7/9 21:48, Jiangfeng Xiao wrote:
>
>
> On 2019/7/9 17:35, Sergei Shtylyov wrote:
>> Hello!
>>
>> On 09.07.2019 6:31, Jiangfeng Xiao wrote:
>>
[...]
>>> @@ -853,6 +867,15 @@ static int hip04_mac_probe(struct platform_device *pdev)
>>> goto init_fail;
>>> }
>>> +#if defined(CONFIG_HI13X1_GMAC)
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>>> + priv->sysctrl_base = devm_ioremap_resource(d, res);
>>
>> There's devm_platform_ioremap_resource() now.
>
> Thank you for your review, Great issue, which makes my code more concise.
>
> I will fix it in v3. Or submit a patch to modify it separately, if maintainer
> applies this patch series.
>
I decided to wait for this series of patches to sync to the mainline
and then fix this based on the mainline.
Because the mainline does not currently have this part of the code,
if I submit the changes, and the patch is accidentally merged into
another branch or another maintainer to handle, a conflict will occur.
As we all know, maintianer has to deal with many commits every day,
I don't want to increase the burden of maintainer.
So I decided to wait until the patch is synced to the mainline
and then modify it, which is more safe.
next prev parent reply other threads:[~2019-07-10 5:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 3:31 [PATCH v2 00/10] net: hisilicon: Add support for HI13X1 to hip04_eth Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 01/10] " Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 02/10] net: hisilicon: Cleanup for got restricted __be32 Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 03/10] net: hisilicon: Cleanup for cast to " Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 04/10] net: hisilicon: HI13X1_GMAX skip write LOCAL_PAGE_REG Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first Jiangfeng Xiao
2019-07-09 9:35 ` Sergei Shtylyov
2019-07-09 13:48 ` Jiangfeng Xiao
2019-07-10 5:05 ` Jiangfeng Xiao [this message]
2019-07-09 3:31 ` [PATCH v2 06/10] net: hisilicon: dt-bindings: Add an field of port-handle Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 07/10] net: hisilicon: Add group field to adapt HI13X1_GMAC Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 08/10] net: hisilicon: Offset buf address " Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 09/10] net: hisilicon: Add an rx_desc " Jiangfeng Xiao
2019-07-09 3:31 ` [PATCH v2 10/10] net: hisilicon: Add an tx_desc " Jiangfeng Xiao
2019-07-09 21:29 ` [PATCH v2 00/10] net: hisilicon: Add support for HI13X1 to hip04_eth David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3eda91-dedc-e687-6a18-b1aec1e9fe63@huawei.com \
--to=xiaojiangfeng@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=jianping.liu@huawei.com \
--cc=leeyou.li@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=xiekunxun@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox