From: Eric Dumazet <eric.dumazet@gmail.com>
To: humbabek <humbabek@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Willem de Bruijn <willemb@google.com>,
Eric Dumazet <edumazet@google.com>,
Kees Cook <keescook@chromium.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Mike Maloney <maloney@google.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move smp_rmb() after load of status
Date: Sat, 7 Jul 2018 15:34:38 -0700 [thread overview]
Message-ID: <5e5dfd01-bad6-55b0-cfd1-75f7ec769e89@gmail.com> (raw)
In-Reply-To: <20180707192319.24771-1-humbabek@gmail.com>
On 07/07/2018 12:23 PM, humbabek wrote:
> Signed-off-by: humbabek <humbabek@gmail.com>
> ---
>
No changelog ?
No comment added explaining why this smp_rmb() move is needed ?
(ie where is the opposite smp_wmb() )
Share with us your thoughts and reasoning, please.
next prev parent reply other threads:[~2018-07-07 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 19:23 [PATCH] move smp_rmb() after load of status humbabek
2018-07-07 22:34 ` Eric Dumazet [this message]
2018-07-08 9:27 ` humbabek
2018-07-08 21:53 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e5dfd01-bad6-55b0-cfd1-75f7ec769e89@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=humbabek@gmail.com \
--cc=keescook@chromium.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=maloney@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).