From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] move smp_rmb() after load of status
Date: Sat, 7 Jul 2018 15:34:38 -0700
Message-ID: <5e5dfd01-bad6-55b0-cfd1-75f7ec769e89@gmail.com>
References: <20180707192319.24771-1-humbabek@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "David S. Miller" <davem@davemloft.net>,
        Willem de Bruijn <willemb@google.com>,
        Eric Dumazet <edumazet@google.com>,
        Kees Cook <keescook@chromium.org>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        Mike Maloney <maloney@google.com>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: humbabek <humbabek@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f66.google.com ([209.85.160.66]:44830 "EHLO
        mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754246AbeGGWel (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 7 Jul 2018 18:34:41 -0400
In-Reply-To: <20180707192319.24771-1-humbabek@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 07/07/2018 12:23 PM, humbabek wrote:
> Signed-off-by: humbabek <humbabek@gmail.com>
> ---
>

No changelog ?

No comment added explaining why this smp_rmb() move is needed ?
(ie where is the opposite smp_wmb() )

Share with us your thoughts and reasoning, please.