RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output pins

["Keller, Jacob E" <jacob.e.keller@intel.com>]

> -----Original Message-----
> From: Keller, Jacob E <jacob.e.keller@intel.com>
> Sent: Tuesday, June 29, 2021 12:29 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>; Richard Cochran
> <richardcochran@gmail.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Cc: davem@davemloft.net; kuba@kernel.org; Machnikowski, Maciej
> <maciej.machnikowski@intel.com>; netdev@vger.kernel.org
> Subject: RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output pins
> 
> 
> 
> > -----Original Message-----
> > From: Keller, Jacob E <jacob.e.keller@intel.com>
> > Sent: Monday, June 28, 2021 3:46 PM
> > To: Richard Cochran <richardcochran@gmail.com>; Nguyen, Anthony L
> > <anthony.l.nguyen@intel.com>
> > Cc: davem@davemloft.net; kuba@kernel.org; Machnikowski, Maciej
> > <maciej.machnikowski@intel.com>; netdev@vger.kernel.org
> > Subject: RE: [PATCH net-next 2/5] ice: add support for auxiliary input/output
> pins
> >
> >
> >
> > > -----Original Message-----
> > > From: Richard Cochran <richardcochran@gmail.com>
> > > Sent: Saturday, June 26, 2021 7:03 AM
> > > To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> > > Cc: davem@davemloft.net; kuba@kernel.org; Machnikowski, Maciej
> > > <maciej.machnikowski@intel.com>; netdev@vger.kernel.org; Keller, Jacob E
> > > <jacob.e.keller@intel.com>
> > > Subject: Re: [PATCH net-next 2/5] ice: add support for auxiliary input/output
> > pins
> > >
> > > On Fri, Jun 25, 2021 at 11:57:30AM -0700, Tony Nguyen wrote:
> > >
> > > > @@ -783,6 +1064,17 @@ static long ice_ptp_create_clock(struct ice_pf *pf)
> > > >  	info = &pf->ptp.info;
> > > >  	dev = ice_pf_to_dev(pf);
> > > >
> > > > +	/* Allocate memory for kernel pins interface */
> > > > +	if (info->n_pins) {
> > > > +		info->pin_config = devm_kcalloc(dev, info->n_pins,
> > > > +						sizeof(*info->pin_config),
> > > > +						GFP_KERNEL);
> > > > +		if (!info->pin_config) {
> > > > +			info->n_pins = 0;
> > > > +			return -ENOMEM;
> > > > +		}
> > > > +	}
> > >
> > > How is this supposed to worK?
> > >
> > > - If n_pins is non-zero, there must also be a ptp_caps.verify method,
> > >   but you don't provide one.
> > >
> >
> > Hmm. Yea, that's missing.
> 
> Ok, turns out this is only intended for a later patch that adds support for some
> pins on E810-T devices, but that work wasn't done yet. We need to split this up
> more, but currently we never set info->n_pins > 0 so this is effectively dead code.
> 
> For now, we need to drop this patch from the series.

Looks like this was pulled already. It shouldn't cause an issue because n_pins is never set to non-zero so it's really just dead code until we can complete the E810-T work.

Thanks,
Jake