From: Paolo Abeni <pabeni@redhat.com>
To: Jinjian Song <songjinjian@hotmail.com>, netdev@vger.kernel.org
Cc: chandrashekar.devegowda@intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
m.chetan.kumar@linux.intel.com,
ricardo.martinez@linux.intel.com, loic.poulain@linaro.org,
ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux-kernel@vger.kernel.com, vsankar@lenovo.com,
danielwinkler@google.com, nmarupaka@google.com,
joey.zhao@fibocom.com, liuqf@fibocom.com, felix.yan@fibocom.com,
Jinjian Song <jinjian.song@fibocom.com>
Subject: Re: [net-next v5 2/4] net: wwan: t7xx: Add sysfs attribute for device state machine
Date: Tue, 23 Jan 2024 13:24:04 +0100 [thread overview]
Message-ID: <5e7757c7ddc4cd0bb4256d893b65aa53b549d052.camel@redhat.com> (raw)
In-Reply-To: <MEYP282MB2697D7CFB233DDAE83F74988BB752@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
On Mon, 2024-01-22 at 17:09 +0800, Jinjian Song wrote:
[...]
> +static ssize_t t7xx_mode_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + int index = 0;
> + struct pci_dev *pdev;
> + struct t7xx_pci_dev *t7xx_dev;
Minor nit: please respect the reverse x-mas tree, here and in more
places below.
Cheers,
Paolo
next prev parent reply other threads:[~2024-01-23 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240122090940.10108-1-songjinjian@hotmail.com>
2024-01-22 9:09 ` [net-next v5 1/4] wwan: core: Add WWAN fastboot port type Jinjian Song
2024-01-22 9:09 ` [net-next v5 2/4] net: wwan: t7xx: Add sysfs attribute for device state machine Jinjian Song
2024-01-23 12:24 ` Paolo Abeni [this message]
2024-01-24 16:56 ` Jinjian Song
2024-01-22 9:09 ` [net-next v5 3/4] net: wwan: t7xx: Infrastructure for early port configuration Jinjian Song
2024-01-22 9:09 ` [net-next v5 4/4] net: wwan: t7xx: Add fastboot WWAN port Jinjian Song
2024-01-23 12:15 ` Paolo Abeni
2024-01-24 16:57 ` Jinjian Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e7757c7ddc4cd0bb4256d893b65aa53b549d052.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=danielwinkler@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=felix.yan@fibocom.com \
--cc=haijun.liu@mediatek.com \
--cc=jinjian.song@fibocom.com \
--cc=joey.zhao@fibocom.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.com \
--cc=liuqf@fibocom.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=nmarupaka@google.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=songjinjian@hotmail.com \
--cc=vsankar@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).