From: "Lifshits, Vitaly" <vitaly.lifshits@intel.com>
To: Simon Horman <horms@kernel.org>, Jacek Kowalski <jacek@jacekk.info>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Vlad URSU <vlad@ursu.me>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v4 2/2] e1000e: ignore uninitialized checksum word on tgp
Date: Tue, 1 Jul 2025 11:58:29 +0300 [thread overview]
Message-ID: <5e880e1c-2ee0-22e7-8bcf-3ab35280db47@intel.com> (raw)
In-Reply-To: <20250630170034.GM41770@horms.kernel.org>
On 6/30/2025 8:00 PM, Simon Horman wrote:
> On Mon, Jun 30, 2025 at 10:35:00AM +0200, Jacek Kowalski wrote:
>> As described by Vitaly Lifshits:
>>
>>> Starting from Tiger Lake, LAN NVM is locked for writes by SW, so the
>>> driver cannot perform checksum validation and correction. This means
>>> that all NVM images must leave the factory with correct checksum and
>>> checksum valid bit set.
>>
>> Unfortunately some systems have left the factory with an uninitialized
>> value of 0xFFFF at register address 0x3F (checksum word location).
>> So on Tiger Lake platform we ignore the computed checksum when such
>> condition is encountered.
>>
>> Signed-off-by: Jacek Kowalski <Jacek@jacekk.info>
>> Tested-by: Vlad URSU <vlad@ursu.me>
>> Fixes: 4051f68318ca9 ("e1000e: Do not take care about recovery NVM checksum")
>> Cc: stable@vger.kernel.org
>
> Thanks for the update.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
Reviewed-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
next prev parent reply other threads:[~2025-07-01 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 8:33 [PATCH v4 0/2] e1000e: disregard NVM checksums for known-bad cases on Tiger Lake Jacek Kowalski
2025-06-30 8:33 ` [PATCH v4 1/2] e1000e: disregard NVM checksum on tgp when valid checksum bit is not set Jacek Kowalski
2025-07-13 11:55 ` [Intel-wired-lan] " Mor Bar-Gabay
2025-06-30 8:35 ` [PATCH v4 2/2] e1000e: ignore uninitialized checksum word on tgp Jacek Kowalski
2025-06-30 17:00 ` Simon Horman
2025-07-01 8:58 ` Lifshits, Vitaly [this message]
2025-07-20 7:12 ` [Intel-wired-lan] " Mor Bar-Gabay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e880e1c-2ee0-22e7-8bcf-3ab35280db47@intel.com \
--to=vitaly.lifshits@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacek@jacekk.info \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vlad@ursu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).